mirror of
https://github.com/nspcc-dev/rfc6979.git
synced 2026-03-01 04:29:26 +00:00
Deprecate this package #6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @roman-khimov on GitHub (Feb 14, 2025).
Is your feature request related to a problem? Please describe.
I'm always frustrated when we're maintaining packages we no longer need. Go 1.24 provides RFC6979 ECDSA signatures out of the box.
Describe the solution you'd like
Check how it works, archive this package if it's OK and if it's not slower than this library.
Describe alternatives you've considered
Keep maintaining it.
Additional context
https://github.com/nspcc-dev/neo-go/issues/3812
@roman-khimov commented on GitHub (Feb 14, 2025):
Notice that crypto/ecdsa returns ASN.1 encoded signature, this can be inconvenient and require some adaptation (see #6 also).
@roman-khimov commented on GitHub (Feb 19, 2025):
Implementation from core is ~30% slower:
It's supposed to be safer though because of constant time functions used instead of
big.Int.@roman-khimov commented on GitHub (Sep 5, 2025):
Leaving this issue open but blocked, core implementation is still slower with Go 1.25 (see #15).