Locode DB skips points that do not have continents in presended geojson #2

New issue

Closed

opened 2025-12-28 18:11:51 +00:00 by sami · 3 comments

sami commented

2025-12-28 18:11:51 +00:00

Owner

Originally created by @carpawell on GitHub (Oct 8, 2021).

Originally assigned to: @alexvanin on GitHub.

Problem

Presented geojson is a little bit rough: some pieces of land may not belong to any continent. It leads to skipping such places and not including them in our DB, e.g. there is no Stockholm in fixed after #2 DB.

Possible solutions:

Do nothing. It is impossible to bootstrap nodes with some locodes then since IR does not know about them.
Try our best: use airport position(s) of the current city(if it has such) and hope that is included in our geojson.
Try our best: find out how to say which continent current County/SubLocation belongs to.
Fill our DB with empty Continent field(or drop it at all).
Make geojson more accurate(almost impossible).
...

I tried to find out if point derivation using the airport(one per city) helps much and got such results:

Total LOCODES: 112396
Does not have continents, but the airport(try one airport per city) does not have a continent too: 151
Neither has continents nor has airport: 3778
Has airports and it can be used as a location: 165

Originally created by @carpawell on GitHub (Oct 8, 2021). Originally assigned to: @alexvanin on GitHub. ## Problem Presented geojson is a little bit rough: some pieces of land may not belong to any continent. It leads to skipping such places and not including them in our DB, e.g. there is no Stockholm in **fixed** after #2 DB. ## Possible solutions: 1. Do nothing. It is impossible to bootstrap nodes with some locodes then since `IR` does not know about them. 2. Try our best: use airport position(s) of the current city(if it has such) and hope that is included in our geojson. 3. Try our best: find out how to say which continent current County/SubLocation belongs to. 4. Fill our DB with empty `Continent` field(or drop it at all). 5. Make geojson more accurate(almost impossible). 6. ... I tried to find out if point derivation using the airport(one per city) helps much and got such results: ``` Total LOCODES: 112396 Does not have continents, but the airport(try one airport per city) does not have a continent too: 151 Neither has continents nor has airport: 3778 Has airports and it can be used as a location: 165 ```

sami

2025-12-28 18:11:51 +00:00

closed this issue
added the
bug

help wanted

question
labels

sami commented

2025-12-28 18:11:53 +00:00

Author

Owner

@carpawell commented on GitHub (Oct 8, 2021):

Why Stockholm is so problematic in our case:

@carpawell commented on GitHub (Oct 8, 2021): Why Stockholm is so problematic in our case: ![image](https://user-images.githubusercontent.com/24619368/136598921-54f4580e-acd7-4c6b-8994-0b2cecb15d08.png)

sami commented

2025-12-28 18:11:53 +00:00

Author

Owner

@alexvanin commented on GitHub (Oct 14, 2021):

Do nothing. Make it is possible to bootstrap nodes without continent.

@alexvanin commented on GitHub (Oct 14, 2021): Do nothing. Make it is possible to bootstrap nodes without continent.

sami commented

2025-12-28 18:11:54 +00:00

Author

Owner

@carpawell commented on GitHub (Oct 14, 2021):

Suggest adding Unknown or Undefined Continent to our db in problem cases.

Should an IR skip such Continent SN attributes or it is OK to have an SN in the netmap with Continent:Unknown attribute?

@carpawell commented on GitHub (Oct 14, 2021): Suggest adding `Unknown` or `Undefined` Continent to our db in problem cases. Should an `IR` skip such `Continent` SN attributes or it is OK to have an SN in the netmap with `Continent:Unknown` attribute?