client: Strange stats on some errors #252

New issue

Open

opened 2025-12-28 18:07:34 +00:00 by sami · 1 comment

sami commented

2025-12-28 18:07:34 +00:00

Owner

Originally created by @cthulhu-rider on GitHub (Dec 9, 2024).

https://pkg.go.dev/github.com/nspcc-dev/neofs-sdk-go/client#PrmInit.SetStatisticCallback option allows to enable internal tracktion of op execution. For some errors, submitted stats look like a successful op completed insta

for example, ObjectDelete on ErrMissingSigner

Current Behavior

some errors are nil-ed and still submitted to the stat handler. With this, such results cannot differ from OK in general. At the same time, some homogeneous errors are transmitted as is (e.g. ObjectHash)

Expected Behavior

either

skip stats for invalid input completely
pass any error to the handler as it is

Possible Solution

i can suppose that it was an attempt to implement 1 to exclude user input errors which is not w/o sense. But for this I'd introduce a classification of errors accessible to the external user and let him decide for himself. Although in this case the internal stats lose their meaning becoming completely implementable around the base client

afaik all current errors are exported and documented, so 2 can be done

Steps to Reproduce

see exec statistics tests from https://github.com/nspcc-dev/neofs-sdk-go/pull/641

Regression

no i guess

Your Environment

Version of the product used: 335d9fe90f

Originally created by @cthulhu-rider on GitHub (Dec 9, 2024). https://pkg.go.dev/github.com/nspcc-dev/neofs-sdk-go/client#PrmInit.SetStatisticCallback option allows to enable internal tracktion of op execution. For some errors, submitted stats look like a successful op completed insta for example, `ObjectDelete` on [`ErrMissingSigner`](https://github.com/nspcc-dev/neofs-sdk-go/blob/335d9fe90f24494944c2888ef385f06f5f81dcfc/client/object_delete.go#L92) ## Current Behavior some errors are nil-ed and still submitted to the stat handler. With this, such results cannot differ from OK in general. At the same time, some homogeneous errors are transmitted as is (e.g. [`ObjectHash`](https://github.com/nspcc-dev/neofs-sdk-go/blob/335d9fe90f24494944c2888ef385f06f5f81dcfc/client/object_hash.go#L105)) ## Expected Behavior either 1. skip stats for invalid input completely 2. pass any error to the handler as it is ## Possible Solution i can suppose that it was an attempt to implement 1 to exclude user input errors which is not w/o sense. But for this I'd introduce a classification of errors accessible to the external user and let him decide for himself. Although in this case the internal stats lose their meaning becoming completely implementable around the base client afaik all current errors are exported and documented, so 2 can be done ## Steps to Reproduce see `exec statistics` tests from https://github.com/nspcc-dev/neofs-sdk-go/pull/641 ## Regression no i guess ## Your Environment * Version of the product used: 335d9fe90f24494944c2888ef385f06f5f81dcfc