mirror of
https://github.com/nspcc-dev/neofs-sdk-go.git
synced 2026-03-01 04:29:18 +00:00
Separate dirs for users and internal ones #228
Labels
No labels
I2
I3
I4
S1
S2
S3
S4
U0
U1
U2
U2
U2
U3
U4
blocked
bug
client
config
discussion
documentation
enhancement
epic
feature
go
good first issue
help wanted
performance
pool
question
security
task
test
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neofs-sdk-go#228
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @carpawell on GitHub (Jul 5, 2024).
The structure of the repo looks a little bit overwhelming now. We have structs for real users (object, nemap, etc) and some non-SDK things (doc, api, scripts, stat). Have you considered moving "SDK" things to a separate folder? Naming can be hard here but still.
Originally posted by @carpawell in https://github.com/nspcc-dev/neofs-sdk-go/pull/591#pullrequestreview-2159245860
@carpawell commented on GitHub (Jul 5, 2024):
It was not a problem before but now we have
api,docs,internal,scripts,statdirs that are not expected to be used by a regular user (poolandwaiterare also questionable to me but ok). We can place the all the "user" code to a separate dir or mark non-usable dirs somehow (e.g. start their name with_).@roman-khimov commented on GitHub (Jul 15, 2024):
statis an SDK thing.docis not an issue.scriptsare tolerable.apican either be hidden (internal) or renamed to something more meaningful. But the last thing I'd want is to move any of the packages we have now.@carpawell commented on GitHub (Jul 15, 2024):
How can it be used? It has
PoolStatand it allows to createPoolStat, used by the Pool only. Why is it at root level?Can not (should not) be used by a user that wants to work with neofs and goes to SDK.
We can move all the "internal" things to
internaland leave all the "user" things as is.