WalletConnect: Support versioned signature schemes #206

New issue

Open

opened 2025-12-28 18:07:25 +00:00 by sami · 2 comments

sami commented

2025-12-28 18:07:25 +00:00

Owner

Originally created by @cthulhu-rider on GitHub (Nov 9, 2023).

Context

NeoFS supports WalletConnect signature scheme implemented here. It was added almost 2y ago and follows algo from neon-js lib of those days

since then neon-js library has moved forward, and, starting from this, now it supports multiple signature versions

Proposal

version the signature scheme similarly to neon-js: add the version to the signature and use it during verification. Missing token will still be treated as legacy schema

Originally created by @cthulhu-rider on GitHub (Nov 9, 2023). ## Context NeoFS supports WalletConnect signature scheme implemented [here](https://github.com/nspcc-dev/neofs-sdk-go/blob/v1.0.0-rc.11/crypto/ecdsa/wallet_connect.go). It was added almost 2y ago and follows [algo](https://github.com/CityOfZion/neon-wallet/blob/1174a9388480e6bbc4f79eb13183c2a573f67ca8/app/context/WalletConnect/helpers.js#L133-L145) from [neon-js](https://github.com/CityOfZion/neon-js) lib of those days since then neon-js library has moved forward, and, starting from [this](https://github.com/CityOfZion/neon-wallet/commit/5a0762fd269b5a32d08937826d8ac9374cc7689d), now it supports multiple signature versions ## Proposal version the signature scheme similarly to neon-js: add the version to the signature and use it during verification. Missing token will still be treated as legacy schema

sami added the

enhancement

labels

2025-12-28 18:07:25 +00:00

sami commented

2025-12-28 18:07:26 +00:00

Author

Owner

@roman-khimov commented on GitHub (Nov 22, 2023):

signMessageNew() looks interesting, signing arbitrary data without any prefixes/suffixes.

@roman-khimov commented on GitHub (Nov 22, 2023): `signMessageNew()` looks interesting, signing arbitrary data without any prefixes/suffixes.

sami commented

2025-12-28 18:07:26 +00:00

Author

Owner

@roman-khimov commented on GitHub (Feb 9, 2024):

It still adds some salt though. And there is also signMessageWithoutSalt provided by DAPI that doesn't do that, but it adds prefix (010001f0).

@roman-khimov commented on GitHub (Feb 9, 2024): It still adds some salt though. And there is also `signMessageWithoutSalt` provided by DAPI that doesn't do that, but it adds prefix (`010001f0`).