Refactor storing of versioning setting in the tree service #273

New issue

Closed

opened 2025-12-28 17:36:48 +00:00 by sami · 3 comments

sami commented

2025-12-28 17:36:48 +00:00

Owner

Originally created by @masterSplinter01 on GitHub (Jul 4, 2022).

Originally assigned to: @masterSplinter01 on GitHub.

Now we store versioning settings as two bools:
https://github.com/nspcc-dev/neofs-s3-gw/blob/master/api/data/info.go#L48

BucketSettings struct {
  IsNoneStatus      bool
  VersioningEnabled bool                     `json:"versioning_enabled"`
  LockConfiguration *ObjectLockConfiguration `json:"lock_configuration"`
}

IsNoneStatus = true, VersioningEnabled = false -- unversioned (if a tree node has not been created)
IsNoneStatus = false, VersioningEnabled = false -- suspended
IsNoneStatus= false, VersioningEnabled = true -- versioned
IsNoneStatus = true, VersioningEnabled = true -- is not possible

Maybe we can store it as a string Unversioned, Versioned, Suspended or as int (line enum: 0 = Unversioned, 1 = Versioned, 2 = Suspended).

It will make code simpler.

BUT it breaks backward compatibility.

Originally created by @masterSplinter01 on GitHub (Jul 4, 2022). Originally assigned to: @masterSplinter01 on GitHub. Now we store versioning settings as two bools: https://github.com/nspcc-dev/neofs-s3-gw/blob/master/api/data/info.go#L48 ``` BucketSettings struct { IsNoneStatus bool VersioningEnabled bool `json:"versioning_enabled"` LockConfiguration *ObjectLockConfiguration `json:"lock_configuration"` } ``` 1. `IsNoneStatus` = true, `VersioningEnabled` = false -- unversioned (if a tree node has not been created) 2. `IsNoneStatus` = false, `VersioningEnabled` = false -- suspended 3. `IsNoneStatus`= false, `VersioningEnabled` = true -- versioned 4. `IsNoneStatus` = true, `VersioningEnabled` = true -- is not possible Maybe we can store it as a string `Unversioned`, `Versioned`, `Suspended` or as int (line `enum`: 0 = `Unversioned`, 1 = `Versioned`, 2 = `Suspended`). It will make code simpler. BUT it breaks backward compatibility.

sami

2025-12-28 17:36:48 +00:00

closed this issue
added the
tree-service

U3
labels

sami commented

2025-12-28 17:36:49 +00:00

Author

Owner

@alexvanin commented on GitHub (Jul 7, 2022):

Blocked the same as https://github.com/nspcc-dev/neofs-s3-gw/issues/533#issuecomment-1157524328

@alexvanin commented on GitHub (Jul 7, 2022): Blocked the same as https://github.com/nspcc-dev/neofs-s3-gw/issues/533#issuecomment-1157524328

sami commented

2025-12-28 17:36:49 +00:00

Author

Owner

@alexvanin commented on GitHub (Jul 18, 2022):

I think it is time to do that according to https://github.com/nspcc-dev/neofs-s3-gw/pull/536#issuecomment-1186941185

@alexvanin commented on GitHub (Jul 18, 2022): I think it is time to do that according to https://github.com/nspcc-dev/neofs-s3-gw/pull/536#issuecomment-1186941185

sami commented

2025-12-28 17:36:49 +00:00

Author

Owner

@alexvanin commented on GitHub (Jul 27, 2022):

Closed in #599

@alexvanin commented on GitHub (Jul 27, 2022): Closed in #599