Notary-enabled AddPeer spends notary deposit for no good reason #994

New issue

Closed

opened 2025-12-28 17:21:25 +00:00 by sami · 1 comment

sami commented

2025-12-28 17:21:25 +00:00

Owner

Originally created by @roman-khimov on GitHub (Mar 15, 2023).

Expected Behavior

Notary deposits are designed to be made once for an extended period of time. If notary subsystem is used properly then notary deposit should stay the same with no fallbacks ever appearing in the chain.

Current Behavior

AddPeer/AddPeerIR relationship is bogus, storage nodes creates a valid transaction calling AddPeer, but this transaction is in fact never completed and always "replaced" by IR nodes with another one calling AddPeerIR. This leads to fallback transaction release for the first transaction and drains notary deposit.

Possible Solution

Fix IR to complete AddPeer call if node data is OK. It's node's responsibility to provide correct data.

Originally created by @roman-khimov on GitHub (Mar 15, 2023). ## Expected Behavior Notary deposits are designed to be made once for an extended period of time. If notary subsystem is used properly then notary deposit should stay the same with no fallbacks ever appearing in the chain. ## Current Behavior AddPeer/AddPeerIR relationship is bogus, storage nodes creates a valid transaction calling AddPeer, but this transaction is in fact never completed and always "replaced" by IR nodes with another one calling AddPeerIR. This leads to fallback transaction release for the first transaction and drains notary deposit. ## Possible Solution Fix IR to complete AddPeer call if node data is OK. It's node's responsibility to provide correct data.