`neofs-adm` waits for potentially useless transactions #745

New issue

Open

opened 2025-12-28 17:20:34 +00:00 by sami · 0 comments

sami commented

2025-12-28 17:20:34 +00:00

Owner

Originally created by @carpawell on GitHub (Sep 15, 2022).

It is common practice to send some TXs, cache their hashes, and wait for their chain inclusion.

Adm CLI stops if one of the TX has not been persisted but does not stop if one of the TX was failed. Moreover, we return only the first not-HALT-err and drop other errors.

I suggest just stopping iterating on any non-HALT TX. It also would simplify the code.

Originally created by @carpawell on GitHub (Sep 15, 2022). It is common practice to send some TXs, cache their hashes, and [wait](https://github.com/nspcc-dev/neofs-node/blob/5321f8ef9c855a6a7737c4f3731469c89c6661af/cmd/neofs-adm/internal/modules/morph/initialize.go#L334-L380) for their chain inclusion. Adm CLI [stops](https://github.com/nspcc-dev/neofs-node/blob/5321f8ef9c855a6a7737c4f3731469c89c6661af/cmd/neofs-adm/internal/modules/morph/initialize.go#L374) if one of the TX has not been persisted but [does not stop](https://github.com/nspcc-dev/neofs-node/blob/5321f8ef9c855a6a7737c4f3731469c89c6661af/cmd/neofs-adm/internal/modules/morph/initialize.go#L368) if one of the TX was failed. Moreover, we return only the first not-HALT-err and drop other errors. I suggest just stopping iterating on any non-HALT TX. It also would simplify the code.