mirror of
https://github.com/nspcc-dev/neofs-node.git
synced 2026-03-01 04:29:10 +00:00
Check that there is no space in cluster for put object when we put object and in-memory cache is on #700
Labels
No labels
I1
I2
I3
I4
S0
S1
S2
S3
S4
U0
U1
U2
U3
U4
blocked
bug
config
dependencies
discussion
documentation
enhancement
enhancement
epic
feature
go
good first issue
help wanted
neofs-adm
neofs-cli
neofs-cli
neofs-cli
neofs-ir
neofs-lens
neofs-storage
neofs-storage
performance
question
security
task
test
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neofs-node#700
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexchetaev on GitHub (Aug 18, 2022).
The issue is that currently we don't check that there is a free disk space available in cluster for put object when we write it through in memory cache. So It can easily seem to the situation then we need to add more disk but can do it. If we restart service for add more disk all object in memory will be lost.
We need the mode for storage node when we check that we have space on the disk before write in memory and return successful response to client.
@cthulhu-rider commented on GitHub (Aug 22, 2022):
Such a pre-check won't fix the issue completely: there could be enough storage space on the check moment, and not enough - micro-interval after. I'd reconsider the exec approach with some sort of
syncflag in the request which preserves data to be left in memory.@fyrchik commented on GitHub (Aug 22, 2022):
After #1584 , we no longer have in-memory cache, so the issue not applies.