IR fee.main_chain config is unused #1505

Closed
opened 2025-12-28 17:35:39 +00:00 by sami · 4 comments
Owner

Originally created by @cthulhu-rider on GitHub (Sep 12, 2025).

Originally assigned to: @End-rey on GitHub.

seems like it is unused since 8150a2e2ea. Better to drop it then

Originally created by @cthulhu-rider on GitHub (Sep 12, 2025). Originally assigned to: @End-rey on GitHub. seems like it is unused since 8150a2e2ea85e849aeba23913a8e2b12028639ea. Better to drop it then
sami 2025-12-28 17:35:39 +00:00
Author
Owner

@roman-khimov commented on GitHub (Sep 12, 2025):

IIRC neofs mainnet contract does use additional fee and it takes values from config. But this needs to be checked again.

@roman-khimov commented on GitHub (Sep 12, 2025): IIRC neofs mainnet contract does use additional fee and it takes values from config. But this needs to be checked again.
Author
Owner

@roman-khimov commented on GitHub (Sep 12, 2025):

nspcc-dev/neofs-node@c61326c004/pkg/innerring/innerring.go (L678)

@roman-khimov commented on GitHub (Sep 12, 2025): https://github.com/nspcc-dev/neofs-node/blob/c61326c0046780407c904f2fd1087800ddb59455/pkg/innerring/innerring.go#L678
Author
Owner

@cthulhu-rider commented on GitHub (Sep 12, 2025):

it is passed but unused. So it's either problem we dont use it, or it is dead cfg

@cthulhu-rider commented on GitHub (Sep 12, 2025): it is passed but unused. So it's either problem we dont use it, or it is dead cfg
Author
Owner

@roman-khimov commented on GitHub (Sep 12, 2025):

It was supposed to use WithStaticFeeIncrement, this configuration should be respected until we have Notary on all main networks.

@roman-khimov commented on GitHub (Sep 12, 2025): It was supposed to use `WithStaticFeeIncrement`, this configuration should be respected until we have Notary on all main networks.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nspcc-dev/neofs-node#1505
No description provided.