mirror of
https://github.com/nspcc-dev/neofs-node.git
synced 2026-03-01 04:29:10 +00:00
Request lifetime trace #1413
Labels
No labels
I1
I2
I3
I4
S0
S1
S2
S3
S4
U0
U1
U2
U3
U4
blocked
bug
config
dependencies
discussion
documentation
enhancement
enhancement
epic
feature
go
good first issue
help wanted
neofs-adm
neofs-cli
neofs-cli
neofs-cli
neofs-ir
neofs-lens
neofs-storage
neofs-storage
performance
question
security
task
test
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neofs-node#1413
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cthulhu-rider on GitHub (May 14, 2025).
Is your feature request related to a problem? Please describe.
I'm always frustrated when I need to recreate the details of the request execution, including chronology. In most cases, input data, i.e. request body, and output status are known. In particular, the status can be
DeadlineExceeded. Processing of any request goes through several stages, sometimes there are quite a lot of themwhen debugging we almost always need to understand what was done and for how long. For example, removing a split object is a multi-step operation involving cryptography, network/disk I/O, etc
at the moment, per-SN log partially allow tracking data movement and inter-SN interactions, while metrics allow tracking duration. But the level of detail leaves much to be desired.
when exploring problems, the main challenges are:
Describe the solution you'd like
support request identity. Have a way to assign system-global UID to any request. Support switchable request tracing: if it's enabled, all requests are identified, and their lives are recorded in detail and measured in time
mostly, these are
debuglog severity and metrics essentially. The only difference i think about is additional costs to metrics. Time measurement is not free. Doing it per-request unconditionally slows down request handling. Mixing and averaging requests also hindersi'll try to formulate the implementation proposal more specifically. For now I will rather highlight the problem
Describe alternatives you've considered
obviously, just keep as is. It's possible that the time spent on implementing a verbose trace will exceed the total time spent on manual debugging. This will also complicate the code
it should be also noted that in production networks it will be impossible to add logs/metrics/printlines, we will have to investigate from what is available
Additional context
i needed to add printlines to my gRPC fork and pull it to the node in #3250
@roman-khimov commented on GitHub (Jun 6, 2025):
I think @carpawell has mentioned Opentelemetry once. Maybe it can help.
@EESergey commented on GitHub (Jun 16, 2025):
We can try to enable tracing of objects of a certain size, for example the main stream is 4096 KB and every 10 seconds a request for objects is 4090 KB. For these objects we output all stages of processing to the log.
@EESergey commented on GitHub (Dec 1, 2025):
Let's proceed step by step, first as described in https://github.com/nspcc-dev/neofs-node/issues/3710