nspcc-dev/neofs-node

Fork 0

mirror of https://github.com/nspcc-dev/neofs-node.git synced 2026-03-01 04:29:10 +00:00

Container removal broke a lot of tests #1175

New issue

Closed

opened 2025-12-28 17:22:04 +00:00 by sami · 8 comments

sami commented

2025-12-28 17:22:04 +00:00

Owner

Originally created by @roman-khimov on GitHub (Dec 26, 2023).

Originally assigned to: @carpawell on GitHub.

Expected Behavior

Like before #2638 merge: https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1168-1703535611/index.html

Current Behavior

https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1169-1703535726/index.html

Possible Solution

Fix it.

Steps to Reproduce (for bugs)

Run testcases.

Regression

Yeah, #2638.

Originally created by @roman-khimov on GitHub (Dec 26, 2023). Originally assigned to: @carpawell on GitHub. ## Expected Behavior Like before #2638 merge: https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1168-1703535611/index.html ## Current Behavior https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1169-1703535726/index.html ## Possible Solution Fix it. ## Steps to Reproduce (for bugs) Run testcases. ## Regression Yeah, #2638.

sami

2025-12-28 17:22:04 +00:00

closed this issue
added the
bug

neofs-storage

S4

I4

U0
labels

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Dec 26, 2023):

what prevents us from tracking tests' breakage before merging?

@cthulhu-rider commented on GitHub (Dec 26, 2023): what prevents us from tracking tests' breakage before merging?

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@roman-khimov commented on GitHub (Dec 26, 2023):

It was ~ok: https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1165-1703509070/index.html

@roman-khimov commented on GitHub (Dec 26, 2023): It was ~ok: https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1165-1703509070/index.html

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Dec 26, 2023):

It was ~ok: https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1165-1703509070/index.html

i see, we run only a bit more than 10% of all tests on PRs. Is there a plan to autorun all tests?

@cthulhu-rider commented on GitHub (Dec 26, 2023): > It was ~ok: https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1165-1703509070/index.html i see, we run only a bit more than 10% of all tests on PRs. Is there a plan to autorun all tests?

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@roman-khimov commented on GitHub (Dec 26, 2023):

These are just different modes, PR and master. 2h+ test suite for every push into PR is too expensive.

@roman-khimov commented on GitHub (Dec 26, 2023): These are just different modes, PR and master. 2h+ test suite for every push into PR is too expensive.

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Dec 26, 2023):

can PR tests be run when the changes are ready-to-merge (manually, or on approvals) somehow? all tests take some time anyway, so it's better to catch failures in the PR, not within merge-detect-PR-merge-detect-PR... flow

@cthulhu-rider commented on GitHub (Dec 26, 2023): can PR tests be run when the changes are ready-to-merge (manually, or on approvals) somehow? all tests take some time anyway, so it's better to catch failures in the PR, not within merge-detect-PR-merge-detect-PR... flow

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@roman-khimov commented on GitHub (Dec 26, 2023):

Only if https://github.com/nspcc-dev/neofs-node/actions/workflows/run-tests.yml is to be parameterized for that (it autodetects PR/master currently). But you'll forget to run it, don't worry.

@roman-khimov commented on GitHub (Dec 26, 2023): Only if https://github.com/nspcc-dev/neofs-node/actions/workflows/run-tests.yml is to be parameterized for that (it autodetects PR/master currently). But you'll forget to run it, don't worry.

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Dec 26, 2023):

forget to run it, don't worry

forget to run - another problem, dont run at all - current

@cthulhu-rider commented on GitHub (Dec 26, 2023): > forget to run it, don't worry forget to run - another problem, dont run at all - current

sami commented

2025-12-28 17:22:04 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Dec 28, 2023):

same OKness again https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1176-1703703416/index.html

@cthulhu-rider commented on GitHub (Dec 28, 2023): same OKness again https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/1176-1703703416/index.html