mirror of
https://github.com/nspcc-dev/neofs-node.git
synced 2026-03-01 04:29:10 +00:00
node: Optimize verification of the request signatures #1167
Labels
No labels
I1
I2
I3
I4
S0
S1
S2
S3
S4
U0
U1
U2
U3
U4
blocked
bug
config
dependencies
discussion
documentation
enhancement
enhancement
epic
feature
go
good first issue
help wanted
neofs-adm
neofs-cli
neofs-cli
neofs-cli
neofs-ir
neofs-lens
neofs-storage
neofs-storage
performance
question
security
task
test
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neofs-node#1167
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cthulhu-rider on GitHub (Dec 18, 2023).
Is your feature request related to a problem? Please describe.
NeoFS API server sometimes wastes large amounts of memory. For example, to verify request signatures, the server decodes messages into intermediate structures, encodes its parts (field-ordered Protocol Buffers V3), verifies signatures and request continues processing.
Describe the solution you'd like
do not perform extra decode-encode stages. To do this, we must arrange the fields in the message without an additional buffer, calculate the checksum and verify the signature. Nothing blocks us from this cuz Protobuf is pretty simple and gRPC lib provides a lot of utilities around it
Describe alternatives you've considered
leave as it is: simpler code but worse performance
@cthulhu-rider commented on GitHub (Jan 29, 2024):
lets postpone this issue a bit, several more fundamental optimizations are coming with v0.40. It'd better to intro current optimization above those ones