Actualize wallets #65

New issue

Open

opened 2025-12-28 18:08:19 +00:00 by sami · 3 comments

sami commented

2025-12-28 18:08:19 +00:00

Owner

Originally created by @notimetoname on GitHub (Jun 19, 2023).

As I understand we have some copypasted accounts for years (nspcc-dev/neofs-dev-env@9e092f3f8e/services/chain/node-wallet.json (L23-L48)? multi-sig? what? @roman-khimov, @AnnaShaleva).

Also, some of them have labels while some do not. I would expect a perfect repo with wallets to be fully labeled. Wallet naming also bothers me (node-wallet.json (what wallet? neo-go? neofs-node?)/wallet.json).

Originally created by @notimetoname on GitHub (Jun 19, 2023). As I understand we have some copypasted accounts for years (https://github.com/nspcc-dev/neofs-dev-env/blob/9e092f3f8e0b27d4cbf67aaf53137f61ccb276b6/services/chain/node-wallet.json#L23-L48? multi-sig? what? @roman-khimov, @AnnaShaleva). Also, some of them [have labels](https://github.com/nspcc-dev/neofs-dev-env/blob/9e092f3f8e0b27d4cbf67aaf53137f61ccb276b6/services/morph_chain/node-wallet.json#L8) while some [do not](https://github.com/nspcc-dev/neofs-dev-env/blob/9e092f3f8e0b27d4cbf67aaf53137f61ccb276b6/services/chain/node-wallet.json#L8). I would expect a perfect repo with wallets to be fully labeled. Wallet naming also bothers me (`node-wallet.json` (what wallet? `neo-go`? `neofs-node`?)/`wallet.json`).

sami added the

discussion

documentation

help wanted

labels

2025-12-28 18:08:19 +00:00

sami commented

2025-12-28 18:08:19 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Jul 3, 2023):

? multi-sig? what?

Yes, it's multisignature account 3/4:

NEO-GO-VM > loadbase64 EwwhAhA6f33QFlWFl/eWDSfFFqQ5T9loueZRVetLAT5AQEBuDCECp7xV/oaE4BGXaNEEujB5W9zIZhnoZK3SYVZyPtGFzWIMIQKzYiv0AXvf4xfFiu1fTHU/IGt9uJYEb6fXdLvEv3+NwgwhA9kMB99j5pDOd5EuEKtRrMlEtmhgI3tgjE+PgwnnHuaZFEGe0Nw6
READY: loaded 147 instructions
NEO-GO-VM 0 > ops
INDEX    OPCODE       PARAMETER
0        PUSH3            <<
1        PUSHDATA1    02103a7f7dd016558597f7960d27c516a4394fd968b9e65155eb4b013e4040406e
36       PUSHDATA1    02a7bc55fe8684e0119768d104ba30795bdcc86619e864add26156723ed185cd62
71       PUSHDATA1    02b3622bf4017bdfe317c58aed5f4c753f206b7db896046fa7d774bbc4bf7f8dc2
106      PUSHDATA1    03d90c07df63e690ce77912e10ab51acc944b66860237b608c4f8f8309e71ee699
141      PUSH4        
142      SYSCALL      System.Crypto.CheckMultisig (9ed0dc3a)

@AnnaShaleva commented on GitHub (Jul 3, 2023): > ? multi-sig? what? Yes, it's multisignature account 3/4: ``` NEO-GO-VM > loadbase64 EwwhAhA6f33QFlWFl/eWDSfFFqQ5T9loueZRVetLAT5AQEBuDCECp7xV/oaE4BGXaNEEujB5W9zIZhnoZK3SYVZyPtGFzWIMIQKzYiv0AXvf4xfFiu1fTHU/IGt9uJYEb6fXdLvEv3+NwgwhA9kMB99j5pDOd5EuEKtRrMlEtmhgI3tgjE+PgwnnHuaZFEGe0Nw6 READY: loaded 147 instructions NEO-GO-VM 0 > ops INDEX OPCODE PARAMETER 0 PUSH3 << 1 PUSHDATA1 02103a7f7dd016558597f7960d27c516a4394fd968b9e65155eb4b013e4040406e 36 PUSHDATA1 02a7bc55fe8684e0119768d104ba30795bdcc86619e864add26156723ed185cd62 71 PUSHDATA1 02b3622bf4017bdfe317c58aed5f4c753f206b7db896046fa7d774bbc4bf7f8dc2 106 PUSHDATA1 03d90c07df63e690ce77912e10ab51acc944b66860237b608c4f8f8309e71ee699 141 PUSH4 142 SYSCALL System.Crypto.CheckMultisig (9ed0dc3a) ```

sami commented

2025-12-28 18:08:19 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Jul 3, 2023):

Generally it's a good practice to add label if there are several accounts into wallet. And even if it's just a sigle account, it's a good idea to properly label it, so +1 from my side for this issue.

@AnnaShaleva commented on GitHub (Jul 3, 2023): Generally it's a good practice to add label if there are several accounts into wallet. And even if it's just a sigle account, it's a good idea to properly label it, so +1 from my side for this issue.

sami commented

2025-12-28 18:08:20 +00:00

Author

Owner

@carpawell commented on GitHub (Jul 3, 2023):