`wallet/wallet.json` is useless #63

New issue

Open

opened 2025-12-28 18:08:18 +00:00 by sami · 4 comments

sami commented

2025-12-28 18:08:18 +00:00

Owner

Originally created by @notimetoname on GitHub (Jun 19, 2023).

With https://github.com/nspcc-dev/neofs-dev-env/pull/238/commits/61fd192eaa410985e14d5466eb2a966c137cb545 that wallet becomes as useful as any other just-generated wallet. None of make commands deposits on it, no container can be created with it, etc. But on the other hand it is still mentioned in README (and in doc dir too).
I would add a separate make target that replenishes wallet/wallet.json and add it as a prerequisite for any up command. @roman-khimov

Originally created by @notimetoname on GitHub (Jun 19, 2023). With https://github.com/nspcc-dev/neofs-dev-env/pull/238/commits/61fd192eaa410985e14d5466eb2a966c137cb545 that wallet becomes as useful as any other just-generated wallet. None of `make` commands deposits on it, no container can be created with it, etc. But on the other hand it is still [mentioned](https://github.com/nspcc-dev/neofs-dev-env/blob/568d05fe9d6206d982ba9164abb7c250d62cfd30/README.md?plain=1#L60-L68) in README (and in `doc` dir [too](https://github.com/nspcc-dev/neofs-dev-env/blob/568d05fe9d6206d982ba9164abb7c250d62cfd30/docs/chain.md?plain=1#L119-L133)). I would add a separate `make` target that replenishes `wallet/wallet.json` and add it as a prerequisite for any `up` command. @roman-khimov

sami added the

bug

documentation

labels

2025-12-28 18:08:18 +00:00

sami commented

2025-12-28 18:08:18 +00:00

Author

Owner

@roman-khimov commented on GitHub (Jun 19, 2023):

IIUC documentation mentions that a GAS transfer should be made, if you can make it easier to use -- OK.

@roman-khimov commented on GitHub (Jun 19, 2023): IIUC documentation mentions that a GAS transfer should be made, if you can make it easier to use -- OK.

sami commented

2025-12-28 18:08:18 +00:00

Author

Owner

@notimetoname commented on GitHub (Jun 19, 2023):

IIUC documentation mentions that a GAS transfer should be made

@roman-khimov, updated the link(s). I read it as "do make prepare.ir and wallet/wallet.json is your door to the NeoFS". And that is how I used to use it.
Now it is just an empty wallet. Making a transfer to it means a user knows what neo-go is and how to use it. So I think we should either drop it or make it great (useful) again.
BTW, why neo-go needs a neofs balance? I think smth is wrong here.

@notimetoname commented on GitHub (Jun 19, 2023): > IIUC documentation mentions that a GAS transfer should be made @roman-khimov, updated the link(s). I read it as "do `make prepare.ir` and `wallet/wallet.json` is your door to the NeoFS". And that is how I used to use it. Now it is just an empty wallet. Making a transfer to it means a user knows what `neo-go` is and how to use it. So I think we _should_ either drop it or make it great (useful) again. BTW, why `neo-go` [needs a neofs balance](https://github.com/nspcc-dev/neofs-dev-env/blob/9e092f3f8e0b27d4cbf67aaf53137f61ccb276b6/bin/deposit.sh#L13)? I think smth is wrong here.

sami commented

2025-12-28 18:08:18 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Dec 20, 2023):

being a DevEnv user, i'd appreciate having both fixed "zero" wallet and the "one with some deposit sufficient for ~80% needs" from the box, e.g.:

wallets/wallet.json with deposit
wallets/wallet_other.json empty
or vice-versa wallets/wallet.json and wallets/wallet_funded.json

@cthulhu-rider commented on GitHub (Dec 20, 2023): being a DevEnv user, i'd appreciate having both fixed "zero" wallet and the "one with some deposit sufficient for ~80% needs" from the box, e.g.: - `wallets/wallet.json` with deposit - `wallets/wallet_other.json` empty or vice-versa `wallets/wallet.json` and `wallets/wallet_funded.json`

sami commented

2025-12-28 18:08:19 +00:00

Author

Owner

@roman-khimov commented on GitHub (Jul 7, 2025):

wallets/wallet.json with GAS and wallets/wallet_empty.json without GAS is a nice combination.

@roman-khimov commented on GitHub (Jul 7, 2025): `wallets/wallet.json` with GAS and `wallets/wallet_empty.json` without GAS is a nice combination.