Bump MaxGasInvoke in morph chain #44

Closed
opened 2025-12-28 18:08:13 +00:00 by sami · 3 comments
Owner

Originally created by @alexvanin on GitHub (Aug 24, 2022).

After #197 it is very convenient to use neofs-adm for contract deployment. However it produces some heavy transactions due to NNS contract invocation. Deploying contract with yadayada.neofs domain requires 30+ GAS.

What do you think about bumping config value for morph chain, let's say, up to 100 GAS. Or maybe use values from our test stands.

/cc @fyrchik @KirillovDenis @carpawell @realloc @anatoly-bogatyrev @aprasolova

Originally created by @alexvanin on GitHub (Aug 24, 2022). After #197 it is very convenient to use neofs-adm for contract deployment. However it produces some heavy transactions due to NNS contract invocation. Deploying contract with `yadayada.neofs` domain requires 30+ GAS. What do you think about bumping config value for morph chain, let's say, up to 100 GAS. Or maybe use values from our test stands. /cc @fyrchik @KirillovDenis @carpawell @realloc @anatoly-bogatyrev @aprasolova
sami 2025-12-28 18:08:13 +00:00
Author
Owner

@realloc commented on GitHub (Aug 24, 2022):

The only problematic use-case for this is initial custom contracts deployment. The GAS price issue is handled by neofs-adm for this case. If we increase the limit we may miss the issues relevant for the real environments where the GAS limit is not that high.

We plan to use dev-env for integration tests, so I'd propose to keep the limit same as we have in public networks.

@realloc commented on GitHub (Aug 24, 2022): The only problematic use-case for this is initial custom contracts deployment. The GAS price issue is handled by `neofs-adm` for this case. If we increase the limit we may miss the issues relevant for the real environments where the GAS limit is not that high. We plan to use dev-env for integration tests, so I'd propose to keep the limit same as we have in public networks.
Author
Owner

@carpawell commented on GitHub (Aug 24, 2022):

@alexvanin, does https://github.com/nspcc-dev/neofs-node/pull/1683 solve the problem? (do not be confused by its title, the solution changed during discussion)

@carpawell commented on GitHub (Aug 24, 2022): @alexvanin, does https://github.com/nspcc-dev/neofs-node/pull/1683 solve the problem? (do not be confused by its title, the solution changed during discussion)
Author
Owner

@alexvanin commented on GitHub (Aug 24, 2022):

@alexvanin, does nspcc-dev/neofs-node#1683 solve the problem? (do not be confused by its title, the solution changed during discussion)

It does (v0.31.0-39-gb54f34d7). I'll close it next week if no other comments will appear.

@alexvanin commented on GitHub (Aug 24, 2022): > @alexvanin, does [nspcc-dev/neofs-node#1683](https://github.com/nspcc-dev/neofs-node/pull/1683) solve the problem? (do not be confused by its title, the solution changed during discussion) It does (v0.31.0-39-gb54f34d7). I'll close it next week if no other comments will appear.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nspcc-dev/neofs-dev-env#44
No description provided.