What should happen when domain expires #97

New issue

Open

opened 2025-12-28 18:08:31 +00:00 by sami · 3 comments

sami commented

2025-12-28 18:08:31 +00:00

Owner

Originally created by @alexvanin on GitHub (Sep 16, 2022).

I suggest to discuss it there and then move issue to a proper repository.

All domains, including top level domains, have expiration parameter. One day sooner or later all domains will expire. Now NNS stores in domain records:

external contract addresses,
system contract addresses,
container aliases.

According to the code, container alias should live for 1 week. Not sure it works this way, but anyway.

nspcc-dev/neofs-contract@70ae2c94e1/container/container_contract.go (L79)

I can't find any Renew invocation by alphabet nodes. I suppose alphabet nodes should create multi signed transaction and renew all available domains once in a while. If not, then I expect that one day the whole system is going to be completely broken. Are my concerns

Is it correct or am I mistaken somewhere?

Originally created by @alexvanin on GitHub (Sep 16, 2022). I suggest to discuss it there and then move issue to a proper repository. All domains, including top level domains, have expiration parameter. One day sooner or later all domains will expire. Now NNS stores in domain records: - external contract addresses, - system contract addresses, - container aliases. According to the code, container alias should live for 1 week. Not sure it works this way, but anyway. https://github.com/nspcc-dev/neofs-contract/blob/70ae2c94e1d2bea81a3abb299e4056c41c1c91b2/container/container_contract.go#L79 I can't find any `Renew` invocation by alphabet nodes. I suppose alphabet nodes should create multi signed transaction and renew all available domains once in a while. If not, then I expect that one day the whole system is going to be completely broken. Are my concerns Is it correct or am I mistaken somewhere?

sami added the

question

labels

2025-12-28 18:08:31 +00:00

sami commented

2025-12-28 18:08:31 +00:00

Author

Owner

@alexvanin commented on GitHub (Oct 3, 2022):

@realloc @fyrchik Consider moving or creating new issue in the neofs-node to control renew process by Alphabet.

@alexvanin commented on GitHub (Oct 3, 2022): @realloc @fyrchik Consider moving or creating new issue in the neofs-node to control renew process by Alphabet.

sami commented

2025-12-28 18:08:31 +00:00

Author

Owner

@alexvanin commented on GitHub (Nov 23, 2022):

container zone is registered by container contract during deployment. Therefore admin of this zone is container contract itself. It means that renew method can be invoked only by container contract.

Consider adding Renew method in container contract that invokes renew method in NNS.

/cc @fyrchik

@alexvanin commented on GitHub (Nov 23, 2022): `container` zone is registered by container contract during deployment. Therefore admin of this zone is container contract itself. It means that `renew` method can be invoked only by container contract. Consider adding `Renew` method in container contract that invokes `renew` method in NNS. /cc @fyrchik

sami commented

2025-12-28 18:08:31 +00:00

Author

Owner

@roman-khimov commented on GitHub (Dec 30, 2022):

We had this happen on mainnet (contract domain expiration, kills IR easily) and it required a manual fix, btw. The fix from #296 is just a ticking bomb for any installation.

@roman-khimov commented on GitHub (Dec 30, 2022): We had this happen on mainnet (contract domain expiration, kills IR easily) and it required a manual fix, btw. The fix from #296 is just a ticking bomb for any installation.