mirror of
https://github.com/nspcc-dev/neofs-contract.git
synced 2026-03-01 04:28:59 +00:00
Update audit contract with new audit result structure #6
Labels
No labels
I1
I2
I3
I4
S1
S2
S3
S4
U1
U2
U3
U4
alphabet
audit
balance
blocked
bug
config
container
discussion
documentation
enhancement
feature
go
good first issue
help wanted
neofs
neofsid
netmap
nns
nns
performance
proxy
question
reputation
security
task
test
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neofs-contract#6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexvanin on GitHub (Dec 16, 2020).
Originally assigned to: @alexvanin on GitHub.
Now audit contract won't transfer payments and should provide interface to store and get audit result structures.
Stable marshaled audit result structures should be stored directly in contract storage and be accessible by the key. The key is a concatenation of epoch number, container ID and inner ring key.
Extra 1: contract can add some prefix to the key, so it will be able to iterate over results by using such prefix.
Extra 2: we group results by using prefixes of
epoch numberorepoch number + container ID.@realloc commented on GitHub (Dec 17, 2020):
Related: nspcc-dev/neofs-api#109
@alexvanin commented on GitHub (Dec 23, 2020):
What should we return on listing operations? Right now in #28 listing functions return binary encoded audit results. But, I suppose, we can hit some output limits if there will be a lot of big audit results.
We can return list of audit result IDs, however there is a small note: we do not store IDs as keys in contract memory (IDs are too big). However we can fetch the value (binary encoded audit result), get key from the value and put it in the result of the listing.
/cc @realloc
@realloc commented on GitHub (Dec 24, 2020):
Let us have
List*methods returning the list of IDs in a shortened format andGet()method accepting ID as argument.