mirror of
https://github.com/nspcc-dev/neofs-contract.git
synced 2026-03-01 04:28:59 +00:00
Provide subscriptions to network config changes #182
Labels
No labels
I1
I2
I3
I4
S1
S2
S3
S4
U1
U2
U3
U4
alphabet
audit
balance
blocked
bug
config
container
discussion
documentation
enhancement
feature
go
good first issue
help wanted
neofs
neofsid
netmap
nns
nns
performance
proxy
question
reputation
security
task
test
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neofs-contract#182
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cthulhu-rider on GitHub (Aug 8, 2024).
Is your feature request related to a problem? Please describe.
there is no current way to subscribe to changes of the NeoFS network settings. This would improve the system's reaction to reconfigs
Describe the solution you'd like
throw per-config notificaitons by the Netmap contract and subscribe to them from the app side
Describe alternatives you've considered
polling, i.e. long delays and often idle requests
Additional context
@carpawell commented on GitHub (Aug 9, 2024):
What it such a notification is missed?
@cthulhu-rider commented on GitHub (Aug 9, 2024):
wont get any worse than when there are no notifications at all
@carpawell commented on GitHub (Aug 9, 2024):
I meant it may get better but the current node code expects to miss any number of notifications at any time, so we cannot rely on it until some changes are done on the nodes side.
@cthulhu-rider commented on GitHub (Aug 9, 2024):
practice shows network config changes extremely rarely. With notifications, nodes could use bigger cache time and catch changes by notifications mostly. Yeah, running node can miss a notification, and it will know about the change later. But normally notifications should not be missed. And this seems a better option than more frequent requests when config stays the same for months
so, worst scenario is not worse while the best one is better. And ur right, this will definitely require catch implementation. The costs seem negligible