Revise log messages of FS chain auto-deployment procedure #149

New issue

Open

opened 2025-12-28 18:08:41 +00:00 by sami · 4 comments

sami commented

2025-12-28 18:08:41 +00:00

Owner

Originally created by @cthulhu-rider on GitHub (Jul 5, 2023).

based on nspcc-dev/neofs-node#2408
refs nspcc-dev/neofs-node#2195

according to @carpawell and @AnnaShaleva remarks, logging of Sidechain deployment routine should be improved in terms of severity and message contents. Overall I agree, but procedure contains a LOT of different conditions and cases, and we should analyze them one-by-one accurately. Since log is log and doesn't affect core behavior much, we decided to resolve log messages (both content and severity levels) within this issue.

it may be also useful to wait until first practical use-cases: with them we'll be able to "beautify" log more objectively

Originally created by @cthulhu-rider on GitHub (Jul 5, 2023). * based on nspcc-dev/neofs-node#2408 * refs nspcc-dev/neofs-node#2195 according to @carpawell and @AnnaShaleva remarks, logging of Sidechain deployment routine should be improved in terms of severity and message contents. Overall I agree, but procedure contains a LOT of different conditions and cases, and we should analyze them one-by-one accurately. Since log is log and doesn't affect core behavior much, we decided to resolve log messages (both content and severity levels) within this issue. it may be also useful to wait until first practical use-cases: with them we'll be able to "beautify" log more objectively

sami added the

enhancement

labels

2025-12-28 18:08:41 +00:00

sami commented

2025-12-28 18:08:42 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Jul 5, 2023):

What we need here is to remove (or convert to DEBUG-level) all logs that are related to the non-suitable notary requests received by the auto-deploy routine. This routine listens to all notary requests signed by the committee. Current code writes INFO-level logs in the following situations:

if Removed event received (removal of notary request from pool
If some non-related notary request with invalid number of signers is received
If received notary request is signed by the receiver node
etc...

IMO, all these situations are not an error, these messages are a part of a standard receiving flow, thus I doubt we should log them at all.

@AnnaShaleva commented on GitHub (Jul 5, 2023): What we need here is to remove (or convert to DEBUG-level) all logs that are related to the non-suitable notary requests received by the auto-deploy routine. This routine listens to *all* notary requests signed by the committee. Current code writes INFO-level logs in the following situations: * if `Removed` event received (removal of notary request from pool * If some non-related notary request with invalid number of signers is received * If received notary request is signed by the receiver node * etc... IMO, all these situations are *not an error*, these messages are a part of a standard receiving flow, thus I doubt we should log them at all.

sami commented

2025-12-28 18:08:42 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Jul 5, 2023):

Ref. https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1245762680, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252049382, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252054120, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252055515, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252057633.

@AnnaShaleva commented on GitHub (Jul 5, 2023): Ref. https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1245762680, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252049382, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252054120, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252055515, https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1252057633.

sami commented

2025-12-28 18:08:42 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Jul 12, 2023):

Ref. https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1260855622.

@AnnaShaleva commented on GitHub (Jul 12, 2023): Ref. https://github.com/nspcc-dev/neofs-node/pull/2408#discussion_r1260855622.

sami commented

2025-12-28 18:08:42 +00:00

Author

Owner

@carpawell commented on GitHub (Jul 13, 2023):