Get contract hashes from NNS during setup #133

New issue

Closed

opened 2025-12-28 18:08:38 +00:00 by sami · 2 comments

sami commented

2025-12-28 18:08:38 +00:00

Owner

Originally created by @roman-khimov on GitHub (Feb 14, 2023).

We have a number of contracts and they use each other for various purposes, so many of them have _deploy parameters to specify hashes of other contracts. These parameters are not very useful and making deployment/upgrades more complicated then they need to be since we always have NNS in sidechain and it always has proper hashes of the target contracts.

Originally created by @roman-khimov on GitHub (Feb 14, 2023). We have a number of contracts and they use each other for various purposes, so many of them have `_deploy` parameters to specify hashes of other contracts. These parameters are not very useful and making deployment/upgrades more complicated then they need to be since we always have NNS in sidechain and it always has proper hashes of the target contracts.

sami

2025-12-28 18:08:38 +00:00

closed this issue
added the
enhancement

config
labels

sami commented

2025-12-28 18:08:39 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Mar 28, 2023):

I'm a bit confused of next deployment parameters:

Container contract depends on Netmap contract address nspcc-dev/neofs-contract@715425a0a7/container/container_contract.go (L146)
Netmap contract depends on Container contract address nspcc-dev/neofs-contract@715425a0a7/netmap/netmap_contract.go (L99)

Will there be a conflict during deployment, or it is assumed that the hashes are known in advance (in the current topic - registered in the NNS)?

@cthulhu-rider commented on GitHub (Mar 28, 2023): I'm a bit confused of next deployment parameters: * `Container` contract depends on `Netmap` contract address https://github.com/nspcc-dev/neofs-contract/blob/715425a0a7e030ec1e0e32157701258dd77d47d9/container/container_contract.go#L146 * `Netmap` contract depends on `Container` contract address https://github.com/nspcc-dev/neofs-contract/blob/715425a0a7e030ec1e0e32157701258dd77d47d9/netmap/netmap_contract.go#L99 Will there be a conflict during deployment, or it is assumed that the hashes are known in advance (in the current topic - registered in the NNS)?

sami commented

2025-12-28 18:08:39 +00:00

Author

Owner

@roman-khimov commented on GitHub (Mar 28, 2023):

The first one is only used during cleanup and can be reworked to not do so, #327.

@roman-khimov commented on GitHub (Mar 28, 2023): The first one is only used during `cleanup` and can be reworked to not do so, #327.