mirror of
https://github.com/nspcc-dev/neofs-contract.git
synced 2026-03-01 04:28:59 +00:00
EACL data size constraint of the container contract #125
Labels
No labels
I1
I2
I3
I4
S1
S2
S3
S4
U1
U2
U3
U4
alphabet
audit
balance
blocked
bug
config
container
discussion
documentation
enhancement
feature
go
good first issue
help wanted
neofs
neofsid
netmap
nns
nns
performance
proxy
question
reputation
security
task
test
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neofs-contract#125
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AnnaShaleva on GitHub (Jan 27, 2023).
The size of
Containerstruct stored in the container contract bynspcc-dev/neofs-contract@dc89137484/container/container_contract.go (L731)is restricted by thestackitem.MaxSizeconstraint (1MB).The struct in the serialized representation takes has the following fields:
We need to estimate the maximum size of the serialized container representation to ensure it fits the limits.
The same thing should be done for eACL
(estimate the maximum size of serialized
eACLrepresentation).Ref. #304.
@roman-khimov commented on GitHub (Jan 27, 2023):
I think it's more limited by
limits.MaxStorageValueLen. Probably this is not a big problem (maybe more relevant for EACLs).@AnnaShaleva commented on GitHub (Jan 30, 2023):
Oh, that's definitely the case, I probably forgot to update my notes before the publishing, because I've also considered this case.
@roman-khimov commented on GitHub (Jul 11, 2025):
It's OK for containers, but https://github.com/nspcc-dev/neofs-s3-gw/issues/1016 and https://github.com/nspcc-dev/neofs-s3-gw/issues/1055 suggest that it's a real problem for EACLs when rules are created automatically. But solving it requires serious EACL rework.