mirror of
https://github.com/nspcc-dev/neo-go.git
synced 2026-03-01 04:28:51 +00:00
DBFT reinitialization after chain height change #261
Labels
No labels
I1
I2
I3
I4
S1
S2
S3
S4
U0
U1
U2
U3
U3
U4
blocked
bug
bug
cli
compiler
config
config
consensus
dependencies
discussion
documentation
enhancement
epic
feature
go
good first issue
help wanted
neotest
network
oracle
performance
question
rpc
security
smartcontract
task
task
task
test
vm
wallet
windows
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neo-go#261
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @roman-khimov on GitHub (Feb 13, 2020).
Originally assigned to: @roman-khimov on GitHub.
If there was a new block accepted and added to the chain of consensus node, the consensus process should restart on this new height regardless of its stage (it's obsolete anyway). #641 fixed a part of this problem in that eventually (on timer expiration) the process will be restarted, but it can take some unpredictable time (especially with timer extensions like in nspcc-dev/dbft#24) and node can easily miss the next consensus round.
At the same time it shouldn't lead to node restarting consensus on every block added during the initial sync, so probably we also need to redefine consensus readiness from "minimum number of peers connected" to "no known peer has better last block index" (which can be a definition of node being in sync with the network).