Go 1.25 upgrade check list #1545

New issue

Open

opened 2025-12-28 17:16:48 +00:00 by sami · 1 comment

sami commented

2025-12-28 17:16:48 +00:00

Owner

Originally created by @roman-khimov on GitHub (Aug 13, 2025).

I'm always frustrated when we're not using the latest and greatest Go. There is Go 1.24 now.

Describe the solution you'd like

Upgrade to Go 1.25 min.

https://go.dev/pkg/testing/synctest should be seriously considered for tests. It's not trivial to adopt, but it has some potential, we have a lot of concurrent code and testing it properly is never fun.

Check ecdsa changes a bit more carefully, looks like we can't leverage them because we're using different formats, but maybe in some cases they're still applicable. https://go.dev/doc/go1.25#cryptoecdsapkgcryptoecdsa

https://go.dev/pkg/reflect#TypeAssert should be used instead of Interface() + type cast, we do have a little of reflection-based code that does it.

Convert wait groups to https://pkg.go.dev/sync#WaitGroup.Go, it's safer to use.

Describe alternatives you've considered

No alternatives.

Additional context

https://go.dev/doc/go1.25

Originally created by @roman-khimov on GitHub (Aug 13, 2025). ## Is your feature request related to a problem? Please describe. I'm always frustrated when we're not using the latest and greatest Go. There is Go 1.24 now. ## Describe the solution you'd like Upgrade to Go 1.25 min. https://go.dev/pkg/testing/synctest should be seriously considered for tests. It's not trivial to adopt, but it has some potential, we have a lot of concurrent code and testing it properly is never fun. Check ecdsa changes a bit more carefully, looks like we can't leverage them because we're using different formats, but maybe in some cases they're still applicable. https://go.dev/doc/go1.25#cryptoecdsapkgcryptoecdsa https://go.dev/pkg/reflect#TypeAssert should be used instead of Interface() + type cast, we do have a little of reflection-based code that does it. Convert wait groups to https://pkg.go.dev/sync#WaitGroup.Go, it's safer to use. ## Describe alternatives you've considered No alternatives. ## Additional context https://go.dev/doc/go1.25