Move common NeoFSBlockFetcher/NeoFSStateFetcher code to helper #1525

New issue

Open

opened 2025-12-28 17:16:45 +00:00 by sami · 3 comments

sami commented

2025-12-28 17:16:45 +00:00

Owner

Originally created by @AliceInHunterland on GitHub (May 20, 2025).

Refactor fetchers services, join and move common get and search operations. ref https://github.com/nspcc-dev/neo-go/pull/3844#discussion_r2093091605

Describe the solution you'd like

no code duplicates.

Describe alternatives you've considered

As is.

Originally created by @AliceInHunterland on GitHub (May 20, 2025). ## Is your feature request related to a problem? Please describe.  Refactor fetchers services, join and move common get and search operations. ref https://github.com/nspcc-dev/neo-go/pull/3844#discussion_r2093091605 ## Describe the solution you'd like  no code duplicates. ## Describe alternatives you've considered  As is.

sami added the

enhancement

labels

2025-12-28 17:16:45 +00:00

sami commented

2025-12-28 17:16:45 +00:00

Author

Owner

@AliceInHunterland commented on GitHub (May 20, 2025):

https://github.com/nspcc-dev/neo-go/pull/3844#discussion_r2095667477 rethink deferring cancel as it leads to memory leaks.

@AliceInHunterland commented on GitHub (May 20, 2025): https://github.com/nspcc-dev/neo-go/pull/3844#discussion_r2095667477 rethink deferring cancel as it leads to memory leaks.

sami commented

2025-12-28 17:16:45 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (May 20, 2025):

rethink deferring cancel as it leads to memory leaks.

@AliceInHunterland it's a separate issue, and it's a bug.

@AnnaShaleva commented on GitHub (May 20, 2025): > rethink deferring cancel as it leads to memory leaks. @AliceInHunterland it's a separate issue, and it's a bug.

sami commented

2025-12-28 17:16:45 +00:00

Author

Owner

@AliceInHunterland commented on GitHub (May 22, 2025):

@AliceInHunterland it's a separate issue, and it's a bug.

At the moment of the implementation of blockfetcher, it was discussed and made intentionally.

@AliceInHunterland commented on GitHub (May 22, 2025): > @AliceInHunterland it's a separate issue, and it's a bug. At the moment of the implementation of blockfetcher, it was discussed and made intentionally.