Possible race in `TestRPC/http/terminatesession/true` #1502

New issue

Open

opened 2025-12-28 17:16:39 +00:00 by sami · 0 comments

sami commented

2025-12-28 17:16:39 +00:00

Owner

Originally created by @AnnaShaleva on GitHub (Apr 3, 2025).

Go 1.23, Windows, 0aaccfd150d50ccaeb58ebd88d36e91967a5f35b, firstly discovered in https://github.com/nspcc-dev/neo-go/actions/runs/14196178657/job/39771726158?pr=3854:

2025-04-01T13:13:55.9778427Z         --- FAIL: TestRPC/http/terminatesession (8.94s)
2025-04-01T13:13:55.9778890Z             --- PASS: TestRPC/http/terminatesession/sessions_disabled (1.66s)
2025-04-01T13:13:55.9779350Z             --- FAIL: TestRPC/http/terminatesession/true (3.51s)
2025-04-01T13:13:55.9779776Z             --- PASS: TestRPC/http/terminatesession/false (0.81s)
2025-04-01T13:13:55.9780207Z             --- PASS: TestRPC/http/terminatesession/expired (2.27s)

2025-04-01T13:12:57.8897138Z === RUN   TestRPC/http/terminatesession/true
2025-04-01T13:12:57.8897334Z === NAME  TestRPC/http
2025-04-01T13:12:57.8898768Z     logger.go:146: 2025-04-01T13:09:13.074Z	DEBUG	processing rpc request	{"method": "invokefunction", "params": "[ebc0c16a76c808cd4dde6bcc063f09e45e331ec7 iterateOverValues]"}
2025-04-01T13:12:57.8900056Z     logger.go:146: 2025-04-01T13:09:15.238Z	DEBUG	processing rpc request	{"method": "terminatesession", "params": "[8ba8f1f7-1e63-4766-8a20-fa2546216070]"}
2025-04-01T13:12:57.8901720Z     logger.go:146: 2025-04-01T13:09:15.238Z	INFO	Error encountered with rpc request	{"code": -107, "method": "terminatesession", "params": "[8ba8f1f7-1e63-4766-8a20-fa2546216070]"}
2025-04-01T13:12:57.8901970Z === NAME  TestRPC/http/terminatesession/true
2025-04-01T13:12:57.8902223Z     server_test.go:3709: 
2025-04-01T13:12:57.8902994Z         	Error Trace:	D:/a/neo-go/neo-go/pkg/services/rpcsrv/server_test.go:3709
2025-04-01T13:12:57.8904196Z         	            				D:/a/neo-go/neo-go/pkg/services/rpcsrv/server_test.go:3282
2025-04-01T13:12:57.8905157Z         	Error:      	Expected nil, but got: &neorpc.Error{Code:-107, Message:"Unknown session", Data:""}
2025-04-01T13:12:57.8905684Z         	Test:       	TestRPC/http/terminatesession/true
2025-04-01T13:12:57.8905932Z     server_test.go:3284: 
2025-04-01T13:12:57.8906612Z         	Error Trace:	D:/a/neo-go/neo-go/pkg/services/rpcsrv/server_test.go:3284
2025-04-01T13:12:57.8906911Z         	Error:      	Received unexpected error:
2025-04-01T13:12:57.8907359Z         	            	unexpected end of JSON input
2025-04-01T13:12:57.8907703Z         	Test:       	TestRPC/http/terminatesession/true
2025-04-01T13:12:57.8907900Z === RUN   TestRPC/http/terminatesession/false
2025-04-01T13:12:57.8908022Z === NAME  TestRPC/http
2025-04-01T13:12:57.8908985Z     logger.go:146: 2025-04-01T13:09:16.209Z	DEBUG	processing rpc request	{"method": "terminatesession", "params": "[a37fe140-4ab8-4e4c-8a22-b0e3bb22087b]"}
2025-04-01T13:12:57.8910037Z     logger.go:146: 2025-04-01T13:09:16.209Z	INFO	Error encountered with rpc request	{"code": -107, "method": "terminatesession", "params": "[a37fe140-4ab8-4e4c-8a22-b0e3bb22087b]"}
2025-04-01T13:12:57.8910313Z === RUN   TestRPC/http/terminatesession/expired

Originally created by @AnnaShaleva on GitHub (Apr 3, 2025). Go 1.23, Windows, 0aaccfd150d50ccaeb58ebd88d36e91967a5f35b, firstly discovered in https://github.com/nspcc-dev/neo-go/actions/runs/14196178657/job/39771726158?pr=3854: ``` 2025-04-01T13:13:55.9778427Z --- FAIL: TestRPC/http/terminatesession (8.94s) 2025-04-01T13:13:55.9778890Z --- PASS: TestRPC/http/terminatesession/sessions_disabled (1.66s) 2025-04-01T13:13:55.9779350Z --- FAIL: TestRPC/http/terminatesession/true (3.51s) 2025-04-01T13:13:55.9779776Z --- PASS: TestRPC/http/terminatesession/false (0.81s) 2025-04-01T13:13:55.9780207Z --- PASS: TestRPC/http/terminatesession/expired (2.27s) ``` ``` 2025-04-01T13:12:57.8897138Z === RUN TestRPC/http/terminatesession/true 2025-04-01T13:12:57.8897334Z === NAME TestRPC/http 2025-04-01T13:12:57.8898768Z logger.go:146: 2025-04-01T13:09:13.074Z DEBUG processing rpc request {"method": "invokefunction", "params": "[ebc0c16a76c808cd4dde6bcc063f09e45e331ec7 iterateOverValues]"} 2025-04-01T13:12:57.8900056Z logger.go:146: 2025-04-01T13:09:15.238Z DEBUG processing rpc request {"method": "terminatesession", "params": "[8ba8f1f7-1e63-4766-8a20-fa2546216070]"} 2025-04-01T13:12:57.8901720Z logger.go:146: 2025-04-01T13:09:15.238Z INFO Error encountered with rpc request {"code": -107, "method": "terminatesession", "params": "[8ba8f1f7-1e63-4766-8a20-fa2546216070]"} 2025-04-01T13:12:57.8901970Z === NAME TestRPC/http/terminatesession/true 2025-04-01T13:12:57.8902223Z server_test.go:3709: 2025-04-01T13:12:57.8902994Z Error Trace: D:/a/neo-go/neo-go/pkg/services/rpcsrv/server_test.go:3709 2025-04-01T13:12:57.8904196Z D:/a/neo-go/neo-go/pkg/services/rpcsrv/server_test.go:3282 2025-04-01T13:12:57.8905157Z Error: Expected nil, but got: &neorpc.Error{Code:-107, Message:"Unknown session", Data:""} 2025-04-01T13:12:57.8905684Z Test: TestRPC/http/terminatesession/true 2025-04-01T13:12:57.8905932Z server_test.go:3284: 2025-04-01T13:12:57.8906612Z Error Trace: D:/a/neo-go/neo-go/pkg/services/rpcsrv/server_test.go:3284 2025-04-01T13:12:57.8906911Z Error: Received unexpected error: 2025-04-01T13:12:57.8907359Z unexpected end of JSON input 2025-04-01T13:12:57.8907703Z Test: TestRPC/http/terminatesession/true 2025-04-01T13:12:57.8907900Z === RUN TestRPC/http/terminatesession/false 2025-04-01T13:12:57.8908022Z === NAME TestRPC/http 2025-04-01T13:12:57.8908985Z logger.go:146: 2025-04-01T13:09:16.209Z DEBUG processing rpc request {"method": "terminatesession", "params": "[a37fe140-4ab8-4e4c-8a22-b0e3bb22087b]"} 2025-04-01T13:12:57.8910037Z logger.go:146: 2025-04-01T13:09:16.209Z INFO Error encountered with rpc request {"code": -107, "method": "terminatesession", "params": "[a37fe140-4ab8-4e4c-8a22-b0e3bb22087b]"} 2025-04-01T13:12:57.8910313Z === RUN TestRPC/http/terminatesession/expired ```