examples neo-go outdated dependencies make tests useless #1480

Open
opened 2025-12-28 17:16:35 +00:00 by sami · 0 comments
Owner

Originally created by @AliceInHunterland on GitHub (Feb 3, 2025).

We didn't catch this https://github.com/nspcc-dev/neo-go/pull/3802 bug earlier because nspcc-dev/neo-go@f09a04d705/examples/zkp/cubic_circuit/go.mod (L8) neo-go dependency wasn't updated with the new release.

Describe the solution you'd like

Update examples dependency automatically. Something like:

cd "$root"/examples/zkp/cubic_circuit || exit 1
go get -u github.com/nspcc-dev/neo-go
go mod tidy

cd "$root"/examples/nft-nd-nns || exit 1
go get -u github.com/nspcc-dev/neo-go
go mod tidy

But update_deps.sh isn't the perfect place for it as it updates only interop dependencies. Maybe dependabot?

Describe alternatives you've considered

Remember about it and update it every time manually.

Originally created by @AliceInHunterland on GitHub (Feb 3, 2025). ## Is your feature request related to a problem? Please describe. <!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when ... --> We didn't catch this https://github.com/nspcc-dev/neo-go/pull/3802 bug earlier because https://github.com/nspcc-dev/neo-go/blob/f09a04d7056e6354ae610a23b135ed5c5dd6f6f5/examples/zkp/cubic_circuit/go.mod#L8 neo-go dependency wasn't updated with the new release. ## Describe the solution you'd like <!-- A clear and concise description of what you want to happen. --> Update examples dependency automatically. Something like: ``` cd "$root"/examples/zkp/cubic_circuit || exit 1 go get -u github.com/nspcc-dev/neo-go go mod tidy cd "$root"/examples/nft-nd-nns || exit 1 go get -u github.com/nspcc-dev/neo-go go mod tidy ``` But update_deps.sh isn't the perfect place for it as it updates only interop dependencies. Maybe dependabot? ## Describe alternatives you've considered <!-- A clear and concise description of any alternative solutions or features you've considered. --> Remember about it and update it every time manually.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nspcc-dev/neo-go#1480
No description provided.