RPC server confuses when logs RPC parameters #1426

New issue

Open

opened 2025-12-28 17:16:24 +00:00 by sami · 2 comments

sami commented

2025-12-28 17:16:24 +00:00

Owner

Originally created by @carpawell on GitHub (Nov 20, 2024).

At some point, you start to check logs to find errors and then you see some strange things that lead you to non-existent bugs...

Current Behavior

I saw processing rpc request {"method": "subscribe", "params": "[transaction_executed ]"} but I am sure it worked ok and params (after transaction_executed) were not an empty string.

Expected Behavior

I could see some string representation of the parameters I sent. It must have one, this was a JSON part at some step.

Possible Solution

I don't know.

Steps to Reproduce

Call some test like nspcc-dev/neo-go@57eec71101/pkg/services/rpcsrv/subscription_test.go (L203-L209) and see that it passes but printed logs are confusing.

Context

Debugging subscription problems may lead to some not-needed deep research for nothing.

Regression

I guess no, @AnnaShaleva said it was kinda ok for years.

Your Environment

v0.106.3

Originally created by @carpawell on GitHub (Nov 20, 2024).  At some point, you start to check logs to find errors and then you see some strange things that lead you to non-existent bugs... ## Current Behavior  I saw `processing rpc request {"method": "subscribe", "params": "[transaction_executed ]"}` but I am sure it worked ok and params (after `transaction_executed`) were not an empty string. ## Expected Behavior  I could see some string representation of the parameters I sent. It must have one, this was a JSON part at some step. ## Possible Solution  I don't know. ## Steps to Reproduce  Call some test like https://github.com/nspcc-dev/neo-go/blob/57eec71101bad9d6d01bbaeecba0a2105f9dbd6b/pkg/services/rpcsrv/subscription_test.go#L203-L209 and see that it passes but printed logs are confusing. ## Context  Debugging subscription problems may lead to some not-needed deep research for nothing. ## Regression  I guess no, @AnnaShaleva said it was kinda ok for years. ## Your Environment v0.106.3

sami added the

bug

rpc

labels

2025-12-28 17:16:24 +00:00

sami commented

2025-12-28 17:16:24 +00:00

Author

Owner

@roman-khimov commented on GitHub (Nov 20, 2024):

We can't log all parameters in their full length, but something can be improved here, because Param.String() is not a regular stringer interface, it's used for string extraction from parameters and not everything is a string. I'd say it's a misuse of "String()" name for a different method.

@roman-khimov commented on GitHub (Nov 20, 2024): We can't log all parameters in their full length, but something can be improved here, because `Param.String()` is not a regular stringer interface, it's used for string extraction from parameters and not everything is a string. I'd say it's a misuse of "String()" name for a different method.

sami commented

2025-12-28 17:16:24 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Jul 8, 2025):

Long arguments should be cropped to log only first 60 bytes of the argument.

@AnnaShaleva commented on GitHub (Jul 8, 2025): Long arguments should be cropped to log only first 60 bytes of the argument.