Simplify native's ActiveIn behaviour #1299

Open
opened 2025-12-28 17:15:56 +00:00 by sami · 0 comments
Owner

Originally created by @AnnaShaleva on GitHub (May 17, 2024).

Native deploy and update code becomes more complicated after #3444. A lot of problems causes nullable native's ActiveIn:
nspcc-dev/neo-go@2d4993a837/pkg/core/interop/context.go (L175-L177)

If we use config.HFDefault instead of null ActiveIn and make ActiveIn to return config.Hardfork instead of *config.Hardfork, it will simplify things a lot and allow to unify native deploy/update code.

Originally created by @AnnaShaleva on GitHub (May 17, 2024). Native deploy and update code becomes more complicated after #3444. A lot of problems causes nullable native's ActiveIn: https://github.com/nspcc-dev/neo-go/blob/2d4993a8375121a5bf073eb37e4dd92451a89f27/pkg/core/interop/context.go#L175-L177 If we use `config.HFDefault` instead of `null` ActiveIn and make ActiveIn to return `config.Hardfork` instead of `*config.Hardfork`, it will simplify things a lot and allow to unify native deploy/update code.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nspcc-dev/neo-go#1299
No description provided.