mirror of
https://github.com/nspcc-dev/neo-go.git
synced 2026-03-01 04:28:51 +00:00
WS-based RPC server tests fail on Windows #1281
Labels
No labels
I1
I2
I3
I4
S1
S2
S3
S4
U0
U1
U2
U3
U3
U4
blocked
bug
bug
cli
compiler
config
config
consensus
dependencies
discussion
documentation
enhancement
epic
feature
go
good first issue
help wanted
neotest
network
oracle
performance
question
rpc
security
smartcontract
task
task
task
test
vm
wallet
windows
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neo-go#1281
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AnnaShaleva on GitHub (Mar 27, 2024).
Originally assigned to: @AnnaShaleva on GitHub.
Go 1.22, Windows, e10c584d422d3997b68128231f05a0c68e67aa49. The failure error
read tcp 127.0.0.1:59625->127.0.0.1:59624: i/o timeoutlooks exactly like in the previously failingTestRPC(#3314). To solve it we should try the same approach as the one used in #3368.@AliceInHunterland commented on GitHub (Mar 27, 2024):
tried the same approach as the one used in https://github.com/nspcc-dev/neo-go/pull/3368 here and had the same Run tests (windows-2022, 1.22)
nspcc-dev/neo-go@dc9b9c0cdf..e10c584d42@AliceInHunterland commented on GitHub (Apr 2, 2024):
Not fixed, still have it on Windows, failure discovered in https://github.com/nspcc-dev/neo-go/pull/3387
@AnnaShaleva commented on GitHub (Apr 3, 2024):
Still not fixed on fresh master, failure discovered in #3396 test run:
From what I see, cleanup problem is not solved.
wsReaderis trying to read from WS connection:And cleanup routine from
initCleanServerAndWSClientis waiting forwsReaderto finish his work:We need to find out what is the reason of
wsReaderroutine hanging on reading from WS connection:_, body, err := ws.ReadMessage()given the fact that we do set read deadline several lines above viaerr := ws.SetReadDeadline(time.Now().Add(5 * time.Second)).@AnnaShaleva commented on GitHub (Apr 4, 2024):
A very similar error is discovered in #3397's Windows test failure in
TestMaxSubscriptions. This test also usesinitCleanServerAndWSClienthelper, I suspect that this helper might be related to the root of the problem. This test also hangs on the same cleanup process.@AnnaShaleva commented on GitHub (Apr 4, 2024):
So the group of tests is affected, not only
TestFilteredNotaryRequestSubscriptions, but alsoTestMaxSubscriptions(reproduced on workflow run) and likely other WS-related RPC server tests.@AnnaShaleva commented on GitHub (Jun 20, 2025):
Not solved, occured on #3918: