mirror of
https://github.com/nspcc-dev/neo-go.git
synced 2026-03-01 04:28:51 +00:00
Race in TestAwaitUtilCancelTx caused by the test design #1274
Labels
No labels
I1
I2
I3
I4
S1
S2
S3
S4
U0
U1
U2
U3
U3
U4
blocked
bug
bug
cli
compiler
config
config
consensus
dependencies
discussion
documentation
enhancement
epic
feature
go
good first issue
help wanted
neotest
network
oracle
performance
question
rpc
security
smartcontract
task
task
task
test
vm
wallet
windows
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neo-go#1274
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AnnaShaleva on GitHub (Mar 19, 2024).
TestAwaitUtilCancelTxis failing sometimes because of the fact that original transaction is being accepted instead of conflicting one. It happens because chain executor's chain continiousely produces blocks, so occasionally the block is being accepted right after main transaction submission. Go 1.22, macOS, firstly discovered at https://github.com/nspcc-dev/neo-go/actions/runs/8328012697/job/22787046121?pr=3357.The possible solution is to add two branches into this test. One branch should handle the case of original transaction acceptance, the other branch should handle the conflicting transaction acceptance. This situation is very natural, so let the test follow both cases (similar to the way how
TestWalletClaimGasworks.@AnnaShaleva commented on GitHub (Apr 1, 2024):
Not fixed, failure discovered in #3387 rebased onto fresh master. The error is:
@AnnaShaleva commented on GitHub (Apr 3, 2024):
Fails with another error case after the last fix. Discovered in https://github.com/nspcc-dev/neo-go/pull/3385.
@AnnaShaleva commented on GitHub (May 13, 2024):
https://github.com/nspcc-dev/neo-go/actions/runs/8999180144/job/24720829287?pr=3431
@AliceInHunterland commented on GitHub (Aug 9, 2024):
another case https://github.com/nspcc-dev/neo-go/actions/runs/10307310424/job/28532327039?pr=3540
@roman-khimov commented on GitHub (Aug 27, 2024):
https://github.com/nspcc-dev/neo-go/actions/runs/10572280163/job/29289709040?pr=3563
@AnnaShaleva commented on GitHub (Nov 15, 2024):