Integrate neotest with local RPC client #1227

New issue

Open

opened 2025-12-28 17:15:41 +00:00 by sami · 3 comments

sami commented

2025-12-28 17:15:41 +00:00

Owner

Originally created by @AnnaShaleva on GitHub (Dec 1, 2023).

Implement the https://github.com/nspcc-dev/neo-go/pull/3233#issuecomment-1829563912.

Originally created by @AnnaShaleva on GitHub (Dec 1, 2023). Implement the https://github.com/nspcc-dev/neo-go/pull/3233#issuecomment-1829563912.

sami added the

rpc

test

enhancement

labels

2025-12-28 17:15:41 +00:00

sami commented

2025-12-28 17:15:41 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Apr 28, 2024):

We also need to refactor all tests where some custom network fee is added for transaction witnesses. Ref. https://github.com/nspcc-dev/neo-go/pull/3425#discussion_r1581848666.

@AnnaShaleva commented on GitHub (Apr 28, 2024): We also need to refactor all tests where some custom network fee is added for transaction witnesses. Ref. https://github.com/nspcc-dev/neo-go/pull/3425#discussion_r1581848666.

sami commented

2025-12-28 17:15:41 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Aug 9, 2024):

Also need to adjust neotest.AddSystemFee (or (*Executor).AddSystemFee) to properly handle RPC GAS limit problem that may happen during system fee calculation. Ref. https://github.com/nspcc-dev/neo-go/pull/3551#discussion_r1711336529.

@AnnaShaleva commented on GitHub (Aug 9, 2024): Also need to adjust `neotest.AddSystemFee` (or `(*Executor).AddSystemFee`) to properly handle RPC GAS limit problem that may happen during system fee calculation. Ref. https://github.com/nspcc-dev/neo-go/pull/3551#discussion_r1711336529.

sami commented

2025-12-28 17:15:41 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Apr 9, 2025):

⬆ to this proposal

i need to adapt https://github.com/nspcc-dev/neo-go/issues/3836 for https://github.com/nspcc-dev/neofs-node/issues/3194. Having ability to instantiate neotest component providing RPC client interface would make unit tests better. For now I'll have to use mock

@cthulhu-rider commented on GitHub (Apr 9, 2025): ⬆ to this proposal i need to adapt https://github.com/nspcc-dev/neo-go/issues/3836 for https://github.com/nspcc-dev/neofs-node/issues/3194. Having ability to instantiate `neotest` component providing RPC client interface would make unit tests better. For now I'll have to use mock