Extend `wallet.Wallet` API to allow saving wallet to a various byte streams #1200

New issue

Open

opened 2025-12-28 17:15:35 +00:00 by sami · 5 comments

sami commented

2025-12-28 17:15:35 +00:00

Owner

Originally created by @cthulhu-rider on GitHub (Oct 23, 2023).

according to docs, the wallet may be written to various byte streams. Instead, package doesn't provide any option to customize output stream other than filepath

suggest to either fix docs or support the documented functionality

Originally created by @cthulhu-rider on GitHub (Oct 23, 2023). according to [docs](https://pkg.go.dev/github.com/nspcc-dev/neo-go@v0.103.0/pkg/wallet#Wallet.Save), the wallet may be written to various byte streams. Instead, [package](https://pkg.go.dev/github.com/nspcc-dev/neo-go@v0.103.0/pkg/wallet) doesn't provide any option to customize output stream other than filepath suggest to either fix docs or support the documented functionality

sami added the

wallet

enhancement

labels

2025-12-28 17:15:35 +00:00

sami commented

2025-12-28 17:15:36 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Oct 23, 2023):

The ability to write wallet to a custom stream may be useful, thus, I suggest to leave the doc as is and implement the custom output (although it may require some CLI/wallet refactoring).

@AnnaShaleva commented on GitHub (Oct 23, 2023): The ability to write wallet to a custom stream may be useful, thus, I suggest to leave the doc as is and implement the custom output (although it may require some CLI/wallet refactoring).

sami commented

2025-12-28 17:15:36 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Dec 11, 2023):

@cthulhu-rider, is there any special demand to use anything except file to store the wallet? Or maybe @roman-khimov.

If not, then https://github.com/nspcc-dev/neo-go/pull/3255#discussion_r1422303697 solves this issue.

@AnnaShaleva commented on GitHub (Dec 11, 2023): @cthulhu-rider, is there any special demand to use anything except file to store the wallet? Or maybe @roman-khimov. If not, then https://github.com/nspcc-dev/neo-go/pull/3255#discussion_r1422303697 solves this issue.

sami commented

2025-12-28 17:15:36 +00:00

Author

Owner

@cthulhu-rider commented on GitHub (Dec 11, 2023):

use anything except file

right now no

@cthulhu-rider commented on GitHub (Dec 11, 2023): > use anything except file right now no

sami commented

2025-12-28 17:15:36 +00:00

Author

Owner

@roman-khimov commented on GitHub (Dec 11, 2023):

We have this API since like forever and it was always sufficient, so I'd adjust the documentation for now and that's it. API extensions can be left for the future.

@roman-khimov commented on GitHub (Dec 11, 2023): We have this API since like forever and it was always sufficient, so I'd adjust the documentation for now and that's it. API extensions can be left for the future.

sami commented

2025-12-28 17:15:36 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Dec 12, 2023):

Good, then let's exclude this issue from 0.105.0, the doc itself is fixed in #3255.

@AnnaShaleva commented on GitHub (Dec 12, 2023): Good, then let's exclude this issue from 0.105.0, the doc itself is fixed in #3255.