mirror of
https://github.com/nspcc-dev/neo-go.git
synced 2026-03-01 04:28:51 +00:00
Implement GAS refund attribute #1039
Labels
No labels
I1
I2
I3
I4
S1
S2
S3
S4
U0
U1
U2
U3
U3
U4
blocked
bug
bug
cli
compiler
config
config
consensus
dependencies
discussion
documentation
enhancement
epic
feature
go
good first issue
help wanted
neotest
network
oracle
performance
question
rpc
security
smartcontract
task
task
task
test
vm
wallet
windows
windows
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
nspcc-dev/neo-go#1039
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @roman-khimov on GitHub (Dec 15, 2022).
See https://github.com/neo-project/neo/issues/2806#issuecomment-1220405200. It's pretty easy to do with NeoGo, we have all of the appropriate data immediately. If it works (and it should, only contract addresses are somewhat of a problem, but it's a known one and it can be worked around), it can be proposed as a proper protocol change for 3.7.0/3.8.0.
@ZhangTao1596 commented on GitHub (Jan 31, 2023):
An initial version is here https://github.com/ZhangTao1596/neo-go/tree/system-fee-refund. I will optimize and test tomorrow.
@roman-khimov commented on GitHub (Jan 31, 2023):
There is a race between
dao.GetTxExecResult()ingetTxCosumed()andstoreBlock()saving this data asynchronously (see a goroutine there), some additional mechanism is needed probably to have this data in the context ofPostPersist(we technically have it, but it may not be yet in DAO).