label="",symbol="GAS" #54

Closed
opened 2025-12-28 18:12:11 +00:00 by sami · 9 comments
Owner

Originally created by @532910 on GitHub (Feb 20, 2024).

Originally assigned to: @smallhive on GitHub.

label="",symbol="GAS"

What's the reason for this garbage? I'm ok to have the ability to group labels, but not in this way.

Originally created by @532910 on GitHub (Feb 20, 2024). Originally assigned to: @smallhive on GitHub. ``` label="",symbol="GAS" ``` What's the reason for this garbage? I'm ok to have the ability to group labels, but not in this way.
sami 2025-12-28 18:12:11 +00:00
Author
Owner

@roman-khimov commented on GitHub (Feb 20, 2024):

It'd be hard to find the reason if we don't know what's going on.

@roman-khimov commented on GitHub (Feb 20, 2024): It'd be hard to find the reason if we don't know what's going on.
Author
Owner

@532910 commented on GitHub (Feb 20, 2024):

curl -s localhost:16512/metrics | grep nep
nspcc-dev/neo-exporter@9740b918b6/config/config.yaml (L28)

@532910 commented on GitHub (Feb 20, 2024): `curl -s localhost:16512/metrics | grep nep` https://github.com/nspcc-dev/neo-exporter/blob/9740b918b66578246cc5a7e3df403adf880b4062/config/config.yaml#L28
Author
Owner

@roman-khimov commented on GitHub (Feb 20, 2024):

symbol just comes from the contract. But label should be respected. Right, @smallhive?

@roman-khimov commented on GitHub (Feb 20, 2024): `symbol` just comes from the contract. But label should be respected. Right, @smallhive?
Author
Owner

@smallhive commented on GitHub (Feb 21, 2024):

label was added as an alternative to symbol. It may be used to give human readable value for unknown tokens

@smallhive commented on GitHub (Feb 21, 2024): label was added as an alternative to symbol. It may be used to give human readable value for unknown tokens
Author
Owner

@roman-khimov commented on GitHub (Feb 21, 2024):

IIUC @532910 has label configured, but not shown in metrics.

@roman-khimov commented on GitHub (Feb 21, 2024): IIUC @532910 has label configured, but not shown in metrics.
Author
Owner

@smallhive commented on GitHub (Feb 29, 2024):

Checked with default config.yaml, latest master

neofs_net_monitor_nep_17_balance{account="3c3f4b84773ef0141576e48c3ff60e5078235891",contract="d2a4cff31913016155e38e474a2c06d08be276cf",label="GAS",symbol="GAS"} 5508.93011
neofs_net_monitor_nep_17_balance{account="40cf93b32c0a328fe8eeae505099147a5adaf646",contract="ef4073a0f2b305a38ec4050e4d3d28bc40ea63f5",label="neo",symbol="NEO"} 0
neofs_net_monitor_nep_17_balance{account="653d7796269ebfa14b632f9a7f09560868d9f646",contract="ef4073a0f2b305a38ec4050e4d3d28bc40ea63f5",label="neo",symbol="NEO"} 0
@smallhive commented on GitHub (Feb 29, 2024): Checked with default config.yaml, latest master ``` neofs_net_monitor_nep_17_balance{account="3c3f4b84773ef0141576e48c3ff60e5078235891",contract="d2a4cff31913016155e38e474a2c06d08be276cf",label="GAS",symbol="GAS"} 5508.93011 neofs_net_monitor_nep_17_balance{account="40cf93b32c0a328fe8eeae505099147a5adaf646",contract="ef4073a0f2b305a38ec4050e4d3d28bc40ea63f5",label="neo",symbol="NEO"} 0 neofs_net_monitor_nep_17_balance{account="653d7796269ebfa14b632f9a7f09560868d9f646",contract="ef4073a0f2b305a38ec4050e4d3d28bc40ea63f5",label="neo",symbol="NEO"} 0 ```
Author
Owner

@roman-khimov commented on GitHub (Feb 29, 2024):

I've checked with a different label, works for me as well.

@roman-khimov commented on GitHub (Feb 29, 2024): I've checked with a different label, works for me as well.
Author
Owner

@532910 commented on GitHub (Mar 1, 2024):

  1. I'm not going to set label in the config. What the hell empty label is shown? I have not asked for it!
  2. What is the reason for such a custom label? I believe label label should be completely removed.
@532910 commented on GitHub (Mar 1, 2024): 1. I'm not going to set `label` in the config. What the hell empty label is shown? I have not asked for it! 2. What is the reason for such a custom label? I believe label `label` should be completely removed.
Author
Owner

@roman-khimov commented on GitHub (Mar 1, 2024):

So basically what you want is to not have label when it's not specified in the config?

@roman-khimov commented on GitHub (Mar 1, 2024): So basically what you want is to not have `label` when it's not specified in the config?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nspcc-dev/neo-exporter#54
No description provided.