Makefile depends on .git, that is missing in release archive #15

New issue

Closed

opened 2025-12-28 18:11:51 +00:00 by sami · 2 comments

sami commented

2025-12-28 18:11:51 +00:00

Owner

Originally created by @532910 on GitHub (Jul 28, 2021).

https://github.com/nspcc-dev/neofs-net-monitor/archive/refs/tags/v0.4.0.tar.gz

% make image  
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
Build neofs-net-monitor docker image
invalid argument "nspccdev/neofs-net-monitor:" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
make: *** [Makefile:24: image] Error 125
zsh: exit 2     make image

Originally created by @532910 on GitHub (Jul 28, 2021). https://github.com/nspcc-dev/neofs-net-monitor/archive/refs/tags/v0.4.0.tar.gz ``` % make image fatal: not a git repository (or any of the parent directories): .git fatal: not a git repository (or any of the parent directories): .git Build neofs-net-monitor docker image invalid argument "nspccdev/neofs-net-monitor:" for "-t, --tag" flag: invalid reference format See 'docker build --help'. make: *** [Makefile:24: image] Error 125 zsh: exit 2 make image ```

sami

2025-12-28 18:11:51 +00:00

closed this issue
added the
enhancement

bug

help wanted
labels

sami commented

2025-12-28 18:11:52 +00:00

Author

Owner

@alexvanin commented on GitHub (Jul 28, 2021):

Pretty much all our repositories use .git dependency in Makefile to obtain version number. Release archive created automatically by github, so I am afraid we can't do anything about that.

Edit 1: we can attach binary if it will help, though.

@alexvanin commented on GitHub (Jul 28, 2021): Pretty much all our repositories use `.git` dependency in Makefile to obtain version number. Release archive created automatically by github, so I am afraid we can't do anything about that. Edit 1: we can attach binary if it will help, though.

sami commented

2025-12-28 18:11:52 +00:00

Author

Owner

@realloc commented on GitHub (Sep 10, 2021):

Based on the internal discussions, the suggestion is to add a VERSION file with the actual release version and use CI to make sure it's correct.

Suggested version detection order:

Get version from git
Get version from VERSION file
Set default devel value

If the approach works fine for this repo, we could reuse it on other projects.

@realloc commented on GitHub (Sep 10, 2021): Based on the internal discussions, the suggestion is to add a VERSION file with the actual release version and use CI to make sure it's correct. Suggested version detection order: - Get version from git - Get version from `VERSION` file - Set default `devel` value If the approach works fine for this repo, we could reuse it on other projects.