Drop useless types from exported package #21

New issue

Closed

opened 2025-12-28 18:12:09 +00:00 by sami · 0 comments

sami commented

2025-12-28 18:12:09 +00:00

Owner

Originally created by @roman-khimov on GitHub (Aug 27, 2024).

Originally assigned to: @End-rey on GitHub.

I'm always frustrated when I look at https://pkg.go.dev/github.com/nspcc-dev/locode-db@v0.6.0/pkg/locodedb, some types are absolutely useless there:

CountryCode
Key
LocationCode

Primarily we're using Record and Get(). It has a Point and a Continent inside. That's it.

Describe the solution you'd like

Drop excessive types.

Describe alternatives you've considered

Keeping as is, confusing to users of this library.

Originally created by @roman-khimov on GitHub (Aug 27, 2024). Originally assigned to: @End-rey on GitHub. ## Is your feature request related to a problem? Please describe. I'm always frustrated when I look at https://pkg.go.dev/github.com/nspcc-dev/locode-db@v0.6.0/pkg/locodedb, some types are absolutely useless there: * CountryCode * Key * LocationCode Primarily we're using `Record` and `Get()`. It has a `Point` and a `Continent` inside. That's it. ## Describe the solution you'd like Drop excessive types. ## Describe alternatives you've considered Keeping as is, confusing to users of this library.