mirror of
https://github.com/nspcc-dev/gh-push-to-neofs.git
synced 2026-03-01 04:28:40 +00:00
Inconsistent NEOFS_NETWORK_DOMAIN parameter #12
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @roman-khimov on GitHub (Nov 14, 2023).
Current Behavior
NEOFS_NETWORK_DOMAINis about some domain, previously we've used it as a generic top-level domain and workflow automatically added stX to it. Now it's a node address effectively which is OK (allows to use private nodes, for example), but it's somewhat misleading in its name and also missing any ability to specify port. It's also unobvious if it supports scheme specification (grpcs://, anyone?).Expected Behavior
Have some
NEOFS_NODEorNEOFS_ENDPOINTparameter that accepts a simple string that is used for RPC endpoint.Possible Solution
Will require 0.2.0 since it's a breaking change (but we can think of some deprecation/compat in 0.1.3).
@roman-khimov commented on GitHub (Aug 30, 2024):
We also have a problem of port specification. Nothing but 8080 is supported at the moment.