mirror of
https://github.com/nspcc-dev/dbft.git
synced 2026-03-01 04:28:38 +00:00
Remove neo-go dependency #13
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fyfyrchik on GitHub (Dec 21, 2023).
It is a circular dependency and sometimes lead to problems (I had some problems GOPROXY=direct after cleaning the cache)
We use only 2 packages from there:
neo-go/pkg/io: to serialize example messages. They are redefined in neo-go (protocol uses interfaces), so example messages can use any serialization scheme (json, gob, rawencoding/binaryhelpers, whatever).neo-go/pkg/util: forutil.Uint*numbers. For these generics could be used.IMO example messages are still good, to use in tests or simulation.
Another option is embed this library to neo-go, but this is more costly.
@roman-khimov commented on GitHub (Dec 21, 2023):
Duplicates #2. I'll reopen it, but it was never a problem to me.