Remove neo-go dependency #13

Closed
opened 2025-12-28 17:07:40 +00:00 by sami · 1 comment
Owner

Originally created by @fyfyrchik on GitHub (Dec 21, 2023).

It is a circular dependency and sometimes lead to problems (I had some problems GOPROXY=direct after cleaning the cache)
We use only 2 packages from there:
neo-go/pkg/io: to serialize example messages. They are redefined in neo-go (protocol uses interfaces), so example messages can use any serialization scheme (json, gob, raw encoding/binary helpers, whatever).
neo-go/pkg/util: for util.Uint* numbers. For these generics could be used.

IMO example messages are still good, to use in tests or simulation.
Another option is embed this library to neo-go, but this is more costly.

Originally created by @fyfyrchik on GitHub (Dec 21, 2023). It is a circular dependency and sometimes lead to problems (I had some problems GOPROXY=direct after cleaning the cache) We use only 2 packages from there: `neo-go/pkg/io`: to serialize example messages. They are redefined in neo-go (protocol uses interfaces), so example messages can use any serialization scheme (json, gob, raw `encoding/binary` helpers, whatever). `neo-go/pkg/util`: for `util.Uint*` numbers. For these generics could be used. IMO example messages are still good, to use in tests or simulation. Another option is embed this library to neo-go, but this is more costly.
sami 2025-12-28 17:07:40 +00:00
Author
Owner

@roman-khimov commented on GitHub (Dec 21, 2023):

Duplicates #2. I'll reopen it, but it was never a problem to me.

@roman-khimov commented on GitHub (Dec 21, 2023): Duplicates #2. I'll reopen it, but it was never a problem to me.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nspcc-dev/dbft#13
No description provided.