Refactor dBFT APIs #12

New issue

Closed

opened 2025-12-28 17:07:39 +00:00 by sami · 2 comments

sami commented

2025-12-28 17:07:39 +00:00

Owner

Originally created by @AnnaShaleva on GitHub (Nov 17, 2023).

Some of dBFT APIs are not used since WithNewBlockFromContext addition. E.g. WithGetConsensusAddress always returns an empty address in NeoGo.

Describe the solution you'd like

We need to review all unused dBFT APIs and remove them.

Originally created by @AnnaShaleva on GitHub (Nov 17, 2023). ## Is your feature request related to a problem? Please describe. Some of dBFT APIs are not used since `WithNewBlockFromContext` addition. E.g. `WithGetConsensusAddress` always returns an empty address in NeoGo. ## Describe the solution you'd like We need to review all unused dBFT APIs and remove them.

sami

2025-12-28 17:07:39 +00:00

closed this issue
added the
enhancement

S1

U3

I2
labels

sami commented

2025-12-28 17:07:40 +00:00

Author

Owner

@AnnaShaleva commented on GitHub (Mar 4, 2024):

Also implement https://github.com/nspcc-dev/dbft/pull/97#issuecomment-1973841163.

@AnnaShaleva commented on GitHub (Mar 4, 2024): Also implement https://github.com/nspcc-dev/dbft/pull/97#issuecomment-1973841163.

sami commented

2025-12-28 17:07:40 +00:00

Author

Owner

@roman-khimov commented on GitHub (Mar 4, 2024):

That's mostly about setters, we want some set of New* and then interface would just expose the data to dbft. Setters are useless here, we never change these values except for initialization of a new payload (either generated one to send or received from the network).

@roman-khimov commented on GitHub (Mar 4, 2024): That's mostly about setters, we want some set of `New*` and then interface would just expose the data to `dbft`. Setters are useless here, we never change these values except for initialization of a new payload (either generated one to send or received from the network).