nspcc-dev/dbft
1
0
Fork 0
mirror of https://github.com/nspcc-dev/dbft.git synced 2026-03-01 04:28:38 +00:00
Code Issues 6 Projects Packages Wiki Activity

Commit signature validation failure #1

New issue
Closed
opened 2025-12-28 17:07:37 +00:00 by sami · 2 comments
sami commented 2025-12-28 17:07:37 +00:00
Owner
Copy link

Originally created by @roman-khimov on GitHub (Jan 30, 2020).

Shouldn't ever happen in local private net:

2020-01-30T15:46:42.709Z        WARN    dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).onCommit
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456
github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
        github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178
2020-01-30T15:46:42.710Z        WARN    dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).onCommit
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456
github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
        github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178
2020-01-30T15:46:42.711Z        DEBUG   dbft@v0.0.0-20200130105505-02c208d154bf/check.go:57     not enough to commit    {"count": 1}
2020-01-30T15:46:42.711Z        WARN    dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).onCommit
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456
github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
        github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178
2020-01-30T15:46:42.711Z        DEBUG   dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:503     recovering finished cv=0/4 preq=0/0 presp=0/4 co=4/4
2020-01-30T15:46:42.711Z        DEBUG   consensus/consensus.go:177      received message        {"from": 1}
2020-01-30T15:46:42.711Z        DEBUG   dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:203     received message        {"type": "RecoveryMessage", "from": 1, "height": 6011, "view": 0, "my_height": 6011, "my_view": 0}
2020-01-30T15:46:42.711Z        DEBUG   dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:489     recovery message received       {"dump": {"Type":65,"ViewNumber":0,"Witness":{"invocation":"40ac2ade580abf272a4a0170842fb3d9e8a9914c0ee9bf0380b15d6287e144e6cea0d5ce47762a8c221b79397979351b97e404dcced895f6fe453a4dc02d43b111","verification":"2102103a7f7dd016558597f7960d27c516a4394fd968b9e65155eb4b013e4040406eac"}}}
2020-01-30T15:46:42.712Z        WARN    dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).onCommit
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456
github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
        github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178
2020-01-30T15:46:42.712Z        WARN    dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).onCommit
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456
github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
        github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178
2020-01-30T15:46:42.713Z        DEBUG   dbft@v0.0.0-20200130105505-02c208d154bf/check.go:57     not enough to commit    {"count": 1}
2020-01-30T15:46:42.713Z        WARN    dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).onCommit
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456
github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
        github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178

three.log

Originally created by @roman-khimov on GitHub (Jan 30, 2020). Shouldn't ever happen in local private net: ``` 2020-01-30T15:46:42.709Z WARN dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).onCommit github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178 2020-01-30T15:46:42.710Z WARN dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).onCommit github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178 2020-01-30T15:46:42.711Z DEBUG dbft@v0.0.0-20200130105505-02c208d154bf/check.go:57 not enough to commit {"count": 1} 2020-01-30T15:46:42.711Z WARN dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).onCommit github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178 2020-01-30T15:46:42.711Z DEBUG dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:503 recovering finished cv=0/4 preq=0/0 presp=0/4 co=4/4 2020-01-30T15:46:42.711Z DEBUG consensus/consensus.go:177 received message {"from": 1} 2020-01-30T15:46:42.711Z DEBUG dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:203 received message {"type": "RecoveryMessage", "from": 1, "height": 6011, "view": 0, "my_height": 6011, "my_view": 0} 2020-01-30T15:46:42.711Z DEBUG dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:489 recovery message received {"dump": {"Type":65,"ViewNumber":0,"Witness":{"invocation":"40ac2ade580abf272a4a0170842fb3d9e8a9914c0ee9bf0380b15d6287e144e6cea0d5ce47762a8c221b79397979351b97e404dcced895f6fe453a4dc02d43b111","verification":"2102103a7f7dd016558597f7960d27c516a4394fd968b9e65155eb4b013e4040406eac"}}} 2020-01-30T15:46:42.712Z WARN dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).onCommit github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178 2020-01-30T15:46:42.712Z WARN dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).onCommit github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178 2020-01-30T15:46:42.713Z DEBUG dbft@v0.0.0-20200130105505-02c208d154bf/check.go:57 not enough to commit {"count": 1} 2020-01-30T15:46:42.713Z WARN dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).onCommit github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:456 github.com/nspcc-dev/dbft.(*DBFT).onRecoveryMessage github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:543 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200130105505-02c208d154bf/dbft.go:242 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:178 ``` [three.log](https://github.com/nspcc-dev/dbft/files/4135606/three.log)
sami closed this issue 2025-12-28 17:07:37 +00:00
sami commented 2025-12-28 17:07:37 +00:00
Author
Owner
Copy link

@roman-khimov commented on GitHub (Jan 31, 2020):

2020-01-31T12:07:17.587Z        WARN    dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).updateExistingPayloads
        github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370
github.com/nspcc-dev/dbft.(*DBFT).onPrepareRequest
        github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:310
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:234
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
        github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:201
2020-01-31T12:07:17.587Z        WARN    dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370     can't validate commit signature
github.com/nspcc-dev/dbft.(*DBFT).updateExistingPayloads
        github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370
github.com/nspcc-dev/dbft.(*DBFT).onPrepareRequest
        github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:310
github.com/nspcc-dev/dbft.(*DBFT).OnReceive
        github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:234
github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop
@roman-khimov commented on GitHub (Jan 31, 2020): ``` 2020-01-31T12:07:17.587Z WARN dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).updateExistingPayloads github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370 github.com/nspcc-dev/dbft.(*DBFT).onPrepareRequest github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:310 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:234 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop github.com/CityOfZion/neo-go@/pkg/consensus/consensus.go:201 2020-01-31T12:07:17.587Z WARN dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370 can't validate commit signature github.com/nspcc-dev/dbft.(*DBFT).updateExistingPayloads github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:370 github.com/nspcc-dev/dbft.(*DBFT).onPrepareRequest github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:310 github.com/nspcc-dev/dbft.(*DBFT).OnReceive github.com/nspcc-dev/dbft@v0.0.0-20200131093116-2117a9426d87/dbft.go:234 github.com/CityOfZion/neo-go/pkg/consensus.(*service).eventLoop ```
sami commented 2025-12-28 17:07:37 +00:00
Author
Owner
Copy link

@fyrchik commented on GitHub (Feb 3, 2020):

Fixed in #22 .

@fyrchik commented on GitHub (Feb 3, 2020): Fixed in #22 .
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
pending-changeview
v0.4.0
v0.3.2
v0.3.1
v0.3.0
v0.2.0
v0.1.0
Labels
Clear labels   
I1

   
I2

   
I3

   
I4

   
S1

   
S2

   
S3

   
S3

   
S4

   
U2

   
U2

   
U3

   
U4

   
blocked

   
bug

   
enhancement

   
feature

   
go

   
help wanted

   
test
No labels
I1
I2
I3
I4
S1
S2
S3
S3
S4
U2
U2
U3
U4
blocked
bug
enhancement
feature
go
help wanted
test
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nspcc-dev/dbft#1
No description provided.